diff options
author | Johan Hovold <jhovold@gmail.com> | 2011-03-22 06:12:22 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-04-13 19:18:33 -0400 |
commit | 94d4c8919de3ae9e2e029ed121adfed43803bb5d (patch) | |
tree | 7d2f63fb259b8a38c3f059ad265715c2435f66d2 /drivers/usb | |
parent | dab54c9f1e26f47a3313300bc1f4dc0eecb47375 (diff) |
USB: cdc-acm: clean up open error handling
No need to kill ctrl urb on errors as this is done later during close.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
-rw-r--r-- | drivers/usb/class/cdc-acm.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 2d8d6b838235..f239e3bd6423 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c | |||
@@ -568,7 +568,7 @@ static int acm_tty_open(struct tty_struct *tty, struct file *filp) | |||
568 | 568 | ||
569 | if (0 > acm_set_control(acm, acm->ctrlout = ACM_CTRL_DTR | ACM_CTRL_RTS) && | 569 | if (0 > acm_set_control(acm, acm->ctrlout = ACM_CTRL_DTR | ACM_CTRL_RTS) && |
570 | (acm->ctrl_caps & USB_CDC_CAP_LINE)) | 570 | (acm->ctrl_caps & USB_CDC_CAP_LINE)) |
571 | goto full_bailout; | 571 | goto bail_out; |
572 | 572 | ||
573 | usb_autopm_put_interface(acm->control); | 573 | usb_autopm_put_interface(acm->control); |
574 | 574 | ||
@@ -592,8 +592,6 @@ out: | |||
592 | mutex_unlock(&open_mutex); | 592 | mutex_unlock(&open_mutex); |
593 | return rv; | 593 | return rv; |
594 | 594 | ||
595 | full_bailout: | ||
596 | usb_kill_urb(acm->ctrlurb); | ||
597 | bail_out: | 595 | bail_out: |
598 | acm->port.count--; | 596 | acm->port.count--; |
599 | mutex_unlock(&acm->mutex); | 597 | mutex_unlock(&acm->mutex); |