diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2013-03-30 13:15:27 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2013-04-09 14:13:10 -0400 |
commit | 96e7d9158f5ae91accb9c81cca14bcd0c996c0cc (patch) | |
tree | 5cf70ad9323cc9e3a9b1c6c0db12e524af4ace54 /drivers/usb | |
parent | 5a787a682047fbf5d250b0c2aed572fb6b7104d6 (diff) |
isp1362-hcd: don't reimplement proc_create_data()
... especially in a racy way
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'drivers/usb')
-rw-r--r-- | drivers/usb/host/isp1362-hcd.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/usb/host/isp1362-hcd.c b/drivers/usb/host/isp1362-hcd.c index 974480c516fa..9137caadb1c8 100644 --- a/drivers/usb/host/isp1362-hcd.c +++ b/drivers/usb/host/isp1362-hcd.c | |||
@@ -2192,14 +2192,11 @@ static void create_debug_file(struct isp1362_hcd *isp1362_hcd) | |||
2192 | { | 2192 | { |
2193 | struct proc_dir_entry *pde; | 2193 | struct proc_dir_entry *pde; |
2194 | 2194 | ||
2195 | pde = create_proc_entry(proc_filename, 0, NULL); | 2195 | pde = proc_create_data(proc_filename, 0, NULL, &proc_ops, isp1362_hcd); |
2196 | if (pde == NULL) { | 2196 | if (pde == NULL) { |
2197 | pr_warning("%s: Failed to create debug file '%s'\n", __func__, proc_filename); | 2197 | pr_warning("%s: Failed to create debug file '%s'\n", __func__, proc_filename); |
2198 | return; | 2198 | return; |
2199 | } | 2199 | } |
2200 | |||
2201 | pde->proc_fops = &proc_ops; | ||
2202 | pde->data = isp1362_hcd; | ||
2203 | isp1362_hcd->pde = pde; | 2200 | isp1362_hcd->pde = pde; |
2204 | } | 2201 | } |
2205 | 2202 | ||