diff options
author | Philipp Zabel <philipp.zabel@gmail.com> | 2008-11-24 15:01:17 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-01-07 13:00:02 -0500 |
commit | 68144e0cc92125f41157ede7b060f83367bc4fe7 (patch) | |
tree | 9f1f5f68fa2d23fb549f2419b8ffb5c5263b15c6 /drivers/usb | |
parent | 6084f1bf0c51a99cbba612ee90a4607cffb8b042 (diff) |
USB: otg: add otg_put_transceiver()
As Russell King points out, calling put_device(otg_transceiver->dev)
directly in driver cleanup paths makes assumptions about otg_transceiver
internals.
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
-rw-r--r-- | drivers/usb/gadget/omap_udc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c index 34e9e393f929..57d9641c6bf8 100644 --- a/drivers/usb/gadget/omap_udc.c +++ b/drivers/usb/gadget/omap_udc.c | |||
@@ -3006,7 +3006,7 @@ cleanup1: | |||
3006 | 3006 | ||
3007 | cleanup0: | 3007 | cleanup0: |
3008 | if (xceiv) | 3008 | if (xceiv) |
3009 | put_device(xceiv->dev); | 3009 | otg_put_transceiver(xceiv); |
3010 | 3010 | ||
3011 | if (cpu_is_omap16xx() || cpu_is_omap24xx()) { | 3011 | if (cpu_is_omap16xx() || cpu_is_omap24xx()) { |
3012 | clk_disable(hhc_clk); | 3012 | clk_disable(hhc_clk); |
@@ -3034,7 +3034,7 @@ static int __exit omap_udc_remove(struct platform_device *pdev) | |||
3034 | 3034 | ||
3035 | pullup_disable(udc); | 3035 | pullup_disable(udc); |
3036 | if (udc->transceiver) { | 3036 | if (udc->transceiver) { |
3037 | put_device(udc->transceiver->dev); | 3037 | otg_put_transceiver(udc->transceiver); |
3038 | udc->transceiver = NULL; | 3038 | udc->transceiver = NULL; |
3039 | } | 3039 | } |
3040 | omap_writew(0, UDC_SYSCON1); | 3040 | omap_writew(0, UDC_SYSCON1); |