diff options
author | Gerd Hoffmann <kraxel@redhat.com> | 2012-09-26 04:28:58 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-09-26 17:13:19 -0400 |
commit | 1994ff405e9c1a8916ca41e093e786262af42b42 (patch) | |
tree | e90693e5ee89e896a2d64468c6ed84d5509f92b5 /drivers/usb/storage | |
parent | 0a2314035cab62cafc38ea11ec5b6f95cf347b38 (diff) |
USB: uas: fix locking
Forgot to unlock in the uas_eh_task_mgmt error paths.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/storage')
-rw-r--r-- | drivers/usb/storage/uas.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 15789097edd6..4218701bb45e 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c | |||
@@ -649,12 +649,14 @@ static int uas_eh_task_mgmt(struct scsi_cmnd *cmnd, | |||
649 | shost_printk(KERN_INFO, shost, | 649 | shost_printk(KERN_INFO, shost, |
650 | "%s: %s: submit sense urb failed\n", | 650 | "%s: %s: submit sense urb failed\n", |
651 | __func__, fname); | 651 | __func__, fname); |
652 | spin_unlock_irqrestore(&devinfo->lock, flags); | ||
652 | return FAILED; | 653 | return FAILED; |
653 | } | 654 | } |
654 | if (uas_submit_task_urb(cmnd, GFP_ATOMIC, function, tag)) { | 655 | if (uas_submit_task_urb(cmnd, GFP_ATOMIC, function, tag)) { |
655 | shost_printk(KERN_INFO, shost, | 656 | shost_printk(KERN_INFO, shost, |
656 | "%s: %s: submit task mgmt urb failed\n", | 657 | "%s: %s: submit task mgmt urb failed\n", |
657 | __func__, fname); | 658 | __func__, fname); |
659 | spin_unlock_irqrestore(&devinfo->lock, flags); | ||
658 | return FAILED; | 660 | return FAILED; |
659 | } | 661 | } |
660 | spin_unlock_irqrestore(&devinfo->lock, flags); | 662 | spin_unlock_irqrestore(&devinfo->lock, flags); |