diff options
| author | Jim Radford <radford@blackbean.org> | 2007-03-13 11:30:50 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-03-19 16:22:18 -0400 |
| commit | 521b85ae66ad40a670b27b0596312d347a89b669 (patch) | |
| tree | d796e1ffe10c47f0b5eeb3d3aeb8ee24f658ae40 /drivers/usb/serial/usb-serial.c | |
| parent | 5851fadce8824d5d4b8fd02c22ae098401f6489e (diff) | |
USB: fix usb-serial regression
This patch reverts d9a7ecacac5f8274d2afce09aadcf37bdb42b93a since it
breaks drivers that need to access the ->port[] array in shutdown
(most of them).
Signed-Off: Jim Radford <radford@blackbean.org>
Acked-by: Mark Lord <mlord@pobox.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/serial/usb-serial.c')
| -rw-r--r-- | drivers/usb/serial/usb-serial.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c index 8511352251f3..7639022cdf84 100644 --- a/drivers/usb/serial/usb-serial.c +++ b/drivers/usb/serial/usb-serial.c | |||
| @@ -138,6 +138,11 @@ static void destroy_serial(struct kref *kref) | |||
| 138 | 138 | ||
| 139 | dbg("%s - %s", __FUNCTION__, serial->type->description); | 139 | dbg("%s - %s", __FUNCTION__, serial->type->description); |
| 140 | 140 | ||
| 141 | serial->type->shutdown(serial); | ||
| 142 | |||
| 143 | /* return the minor range that this device had */ | ||
| 144 | return_serial(serial); | ||
| 145 | |||
| 141 | for (i = 0; i < serial->num_ports; ++i) | 146 | for (i = 0; i < serial->num_ports; ++i) |
| 142 | serial->port[i]->open_count = 0; | 147 | serial->port[i]->open_count = 0; |
| 143 | 148 | ||
| @@ -148,12 +153,6 @@ static void destroy_serial(struct kref *kref) | |||
| 148 | serial->port[i] = NULL; | 153 | serial->port[i] = NULL; |
| 149 | } | 154 | } |
| 150 | 155 | ||
| 151 | if (serial->type->shutdown) | ||
| 152 | serial->type->shutdown(serial); | ||
| 153 | |||
| 154 | /* return the minor range that this device had */ | ||
| 155 | return_serial(serial); | ||
| 156 | |||
| 157 | /* If this is a "fake" port, we have to clean it up here, as it will | 156 | /* If this is a "fake" port, we have to clean it up here, as it will |
| 158 | * not get cleaned up in port_release() as it was never registered with | 157 | * not get cleaned up in port_release() as it was never registered with |
| 159 | * the driver core */ | 158 | * the driver core */ |
