diff options
author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2008-04-08 12:16:06 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-04-25 00:16:55 -0400 |
commit | a5b6f60c5a30c494017c7a2d11c4067f90d3d0df (patch) | |
tree | 2f80d1a6c2655c5c12f40cafbc47516284934d42 /drivers/usb/serial/pl2303.c | |
parent | 441b62c1edb986827154768d89bbac0ba779984f (diff) |
usb serial: more fixes and groundwork for tty changes
- If a termios change fails due to lack of memory we should copy the
old settings back over as the device has not changed
- Note various locking problems
- kl5kusb105 had various remaining tty flag handling problems
- Make safe_serial use tty_insert_flip_string not open coded loops
- set termios speed properly in usb_serial
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/serial/pl2303.c')
-rw-r--r-- | drivers/usb/serial/pl2303.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 2b4ab371c762..c60930ec9341 100644 --- a/drivers/usb/serial/pl2303.c +++ b/drivers/usb/serial/pl2303.c | |||
@@ -546,6 +546,8 @@ static void pl2303_set_termios(struct usb_serial_port *port, | |||
546 | buf = kzalloc(7, GFP_KERNEL); | 546 | buf = kzalloc(7, GFP_KERNEL); |
547 | if (!buf) { | 547 | if (!buf) { |
548 | dev_err(&port->dev, "%s - out of memory.\n", __func__); | 548 | dev_err(&port->dev, "%s - out of memory.\n", __func__); |
549 | /* Report back no change occurred */ | ||
550 | *port->tty->termios = *old_termios; | ||
549 | return; | 551 | return; |
550 | } | 552 | } |
551 | 553 | ||