aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial/pl2303.c
diff options
context:
space:
mode:
authorAlan Cox <alan@linux.intel.com>2009-07-09 08:36:22 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2009-07-10 22:17:22 -0400
commit24a15a62dcb1968bf4ffdae55c88fa934d971180 (patch)
tree39a2231da07c6a47a4b66baf0158591a9739ac8f /drivers/usb/serial/pl2303.c
parent4cd1de0afaaa45309f34d7282ea4c07d9b56a3ff (diff)
tty: Fix USB kref leak
The sysrq code acquired a kref leak. Fix it by passing the tty separately from the caller (thus effectively using the callers kref which all the callers hold anyway) Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/usb/serial/pl2303.c')
-rw-r--r--drivers/usb/serial/pl2303.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index ec6c132a25b5..8835802067f7 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -1038,7 +1038,7 @@ static void pl2303_read_bulk_callback(struct urb *urb)
1038 if (line_status & UART_OVERRUN_ERROR) 1038 if (line_status & UART_OVERRUN_ERROR)
1039 tty_insert_flip_char(tty, 0, TTY_OVERRUN); 1039 tty_insert_flip_char(tty, 0, TTY_OVERRUN);
1040 for (i = 0; i < urb->actual_length; ++i) 1040 for (i = 0; i < urb->actual_length; ++i)
1041 if (!usb_serial_handle_sysrq_char(port, data[i])) 1041 if (!usb_serial_handle_sysrq_char(tty, port, data[i]))
1042 tty_insert_flip_char(tty, data[i], tty_flag); 1042 tty_insert_flip_char(tty, data[i], tty_flag);
1043 tty_flip_buffer_push(tty); 1043 tty_flip_buffer_push(tty);
1044 } 1044 }