diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-05-03 19:44:43 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-05-03 19:44:43 -0400 |
commit | 77b3b30d18c1a4301441ca1be8bb404ac82408ae (patch) | |
tree | 7227aac877cddde79a552ffd13ab86be7202915c /drivers/usb/serial/oti6858.c | |
parent | e79a8a4be4a741c3b4608dcdaaffb172f7b01877 (diff) |
USB: oti6858.c: remove dbg() tracing calls
dbg() was used a lot a long time ago to trace code flow. Now that we have
ftrace, this isn't needed at all, so remove these calls.
CC: Johan Hovold <jhovold@gmail.com>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/serial/oti6858.c')
-rw-r--r-- | drivers/usb/serial/oti6858.c | 29 |
1 files changed, 0 insertions, 29 deletions
diff --git a/drivers/usb/serial/oti6858.c b/drivers/usb/serial/oti6858.c index 8bc8ea45825b..d4bce46df2d1 100644 --- a/drivers/usb/serial/oti6858.c +++ b/drivers/usb/serial/oti6858.c | |||
@@ -211,8 +211,6 @@ static void setup_line(struct work_struct *work) | |||
211 | unsigned long flags; | 211 | unsigned long flags; |
212 | int result; | 212 | int result; |
213 | 213 | ||
214 | dbg("%s(port = %d)", __func__, port->number); | ||
215 | |||
216 | new_setup = kmalloc(OTI6858_CTRL_PKT_SIZE, GFP_KERNEL); | 214 | new_setup = kmalloc(OTI6858_CTRL_PKT_SIZE, GFP_KERNEL); |
217 | if (new_setup == NULL) { | 215 | if (new_setup == NULL) { |
218 | dev_err(&port->dev, "%s(): out of memory!\n", __func__); | 216 | dev_err(&port->dev, "%s(): out of memory!\n", __func__); |
@@ -282,8 +280,6 @@ static void send_data(struct work_struct *work) | |||
282 | unsigned long flags; | 280 | unsigned long flags; |
283 | u8 *allow; | 281 | u8 *allow; |
284 | 282 | ||
285 | dbg("%s(port = %d)", __func__, port->number); | ||
286 | |||
287 | spin_lock_irqsave(&priv->lock, flags); | 283 | spin_lock_irqsave(&priv->lock, flags); |
288 | if (priv->flags.write_urb_in_use) { | 284 | if (priv->flags.write_urb_in_use) { |
289 | spin_unlock_irqrestore(&priv->lock, flags); | 285 | spin_unlock_irqrestore(&priv->lock, flags); |
@@ -379,8 +375,6 @@ static int oti6858_startup(struct usb_serial *serial) | |||
379 | static int oti6858_write(struct tty_struct *tty, struct usb_serial_port *port, | 375 | static int oti6858_write(struct tty_struct *tty, struct usb_serial_port *port, |
380 | const unsigned char *buf, int count) | 376 | const unsigned char *buf, int count) |
381 | { | 377 | { |
382 | dbg("%s(port = %d, count = %d)", __func__, port->number, count); | ||
383 | |||
384 | if (!count) | 378 | if (!count) |
385 | return count; | 379 | return count; |
386 | 380 | ||
@@ -395,8 +389,6 @@ static int oti6858_write_room(struct tty_struct *tty) | |||
395 | int room = 0; | 389 | int room = 0; |
396 | unsigned long flags; | 390 | unsigned long flags; |
397 | 391 | ||
398 | dbg("%s(port = %d)", __func__, port->number); | ||
399 | |||
400 | spin_lock_irqsave(&port->lock, flags); | 392 | spin_lock_irqsave(&port->lock, flags); |
401 | room = kfifo_avail(&port->write_fifo); | 393 | room = kfifo_avail(&port->write_fifo); |
402 | spin_unlock_irqrestore(&port->lock, flags); | 394 | spin_unlock_irqrestore(&port->lock, flags); |
@@ -410,8 +402,6 @@ static int oti6858_chars_in_buffer(struct tty_struct *tty) | |||
410 | int chars = 0; | 402 | int chars = 0; |
411 | unsigned long flags; | 403 | unsigned long flags; |
412 | 404 | ||
413 | dbg("%s(port = %d)", __func__, port->number); | ||
414 | |||
415 | spin_lock_irqsave(&port->lock, flags); | 405 | spin_lock_irqsave(&port->lock, flags); |
416 | chars = kfifo_len(&port->write_fifo); | 406 | chars = kfifo_len(&port->write_fifo); |
417 | spin_unlock_irqrestore(&port->lock, flags); | 407 | spin_unlock_irqrestore(&port->lock, flags); |
@@ -437,8 +427,6 @@ static void oti6858_set_termios(struct tty_struct *tty, | |||
437 | __le16 divisor; | 427 | __le16 divisor; |
438 | int br; | 428 | int br; |
439 | 429 | ||
440 | dbg("%s(port = %d)", __func__, port->number); | ||
441 | |||
442 | if (!tty) { | 430 | if (!tty) { |
443 | dbg("%s(): no tty structures", __func__); | 431 | dbg("%s(): no tty structures", __func__); |
444 | return; | 432 | return; |
@@ -545,8 +533,6 @@ static int oti6858_open(struct tty_struct *tty, struct usb_serial_port *port) | |||
545 | unsigned long flags; | 533 | unsigned long flags; |
546 | int result; | 534 | int result; |
547 | 535 | ||
548 | dbg("%s(port = %d)", __func__, port->number); | ||
549 | |||
550 | usb_clear_halt(serial->dev, port->write_urb->pipe); | 536 | usb_clear_halt(serial->dev, port->write_urb->pipe); |
551 | usb_clear_halt(serial->dev, port->read_urb->pipe); | 537 | usb_clear_halt(serial->dev, port->read_urb->pipe); |
552 | 538 | ||
@@ -602,8 +588,6 @@ static void oti6858_close(struct usb_serial_port *port) | |||
602 | struct oti6858_private *priv = usb_get_serial_port_data(port); | 588 | struct oti6858_private *priv = usb_get_serial_port_data(port); |
603 | unsigned long flags; | 589 | unsigned long flags; |
604 | 590 | ||
605 | dbg("%s(port = %d)", __func__, port->number); | ||
606 | |||
607 | spin_lock_irqsave(&port->lock, flags); | 591 | spin_lock_irqsave(&port->lock, flags); |
608 | /* clear out any remaining data in the buffer */ | 592 | /* clear out any remaining data in the buffer */ |
609 | kfifo_reset_out(&port->write_fifo); | 593 | kfifo_reset_out(&port->write_fifo); |
@@ -660,8 +644,6 @@ static int oti6858_tiocmget(struct tty_struct *tty) | |||
660 | unsigned pin_state; | 644 | unsigned pin_state; |
661 | unsigned result = 0; | 645 | unsigned result = 0; |
662 | 646 | ||
663 | dbg("%s(port = %d)", __func__, port->number); | ||
664 | |||
665 | spin_lock_irqsave(&priv->lock, flags); | 647 | spin_lock_irqsave(&priv->lock, flags); |
666 | pin_state = priv->status.pin_state & PIN_MASK; | 648 | pin_state = priv->status.pin_state & PIN_MASK; |
667 | spin_unlock_irqrestore(&priv->lock, flags); | 649 | spin_unlock_irqrestore(&priv->lock, flags); |
@@ -744,8 +726,6 @@ static void oti6858_release(struct usb_serial *serial) | |||
744 | { | 726 | { |
745 | int i; | 727 | int i; |
746 | 728 | ||
747 | dbg("%s()", __func__); | ||
748 | |||
749 | for (i = 0; i < serial->num_ports; ++i) | 729 | for (i = 0; i < serial->num_ports; ++i) |
750 | kfree(usb_get_serial_port_data(serial->port[i])); | 730 | kfree(usb_get_serial_port_data(serial->port[i])); |
751 | } | 731 | } |
@@ -757,9 +737,6 @@ static void oti6858_read_int_callback(struct urb *urb) | |||
757 | int transient = 0, can_recv = 0, resubmit = 1; | 737 | int transient = 0, can_recv = 0, resubmit = 1; |
758 | int status = urb->status; | 738 | int status = urb->status; |
759 | 739 | ||
760 | dbg("%s(port = %d, status = %d)", | ||
761 | __func__, port->number, status); | ||
762 | |||
763 | switch (status) { | 740 | switch (status) { |
764 | case 0: | 741 | case 0: |
765 | /* success */ | 742 | /* success */ |
@@ -876,9 +853,6 @@ static void oti6858_read_bulk_callback(struct urb *urb) | |||
876 | int status = urb->status; | 853 | int status = urb->status; |
877 | int result; | 854 | int result; |
878 | 855 | ||
879 | dbg("%s(port = %d, status = %d)", | ||
880 | __func__, port->number, status); | ||
881 | |||
882 | spin_lock_irqsave(&priv->lock, flags); | 856 | spin_lock_irqsave(&priv->lock, flags); |
883 | priv->flags.read_urb_in_use = 0; | 857 | priv->flags.read_urb_in_use = 0; |
884 | spin_unlock_irqrestore(&priv->lock, flags); | 858 | spin_unlock_irqrestore(&priv->lock, flags); |
@@ -910,9 +884,6 @@ static void oti6858_write_bulk_callback(struct urb *urb) | |||
910 | int status = urb->status; | 884 | int status = urb->status; |
911 | int result; | 885 | int result; |
912 | 886 | ||
913 | dbg("%s(port = %d, status = %d)", | ||
914 | __func__, port->number, status); | ||
915 | |||
916 | switch (status) { | 887 | switch (status) { |
917 | case 0: | 888 | case 0: |
918 | /* success */ | 889 | /* success */ |