diff options
author | Johan Hovold <jhovold@gmail.com> | 2011-11-06 13:06:28 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-11-15 13:33:16 -0500 |
commit | 5833041f1b130e5823a99d03b14538282e5ad345 (patch) | |
tree | 394caf266125dd725d47470a11cb5840040130ec /drivers/usb/serial/mct_u232.c | |
parent | 016af7ec49836342c3b35166792c8d73a360571c (diff) |
USB: serial: remove unnecessary reinitialisations of urb->dev
Remove unnecessary reinitialisations of urb->dev before each submission,
which were based on the (no longer valid) assumption that serial->dev
will be set to NULL on close.
Compile-only tested.
Cc: Matthias Bruestle and Harald Welte <support@reiner-sct.com>
Cc: Lonnie Mendez <dignome@gmail.com>
Cc: Peter Berger <pberger@brimson.com>
Cc: Al Borchers <alborchers@steinerpoint.com>
Cc: Support Department <support@connecttech.com>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/serial/mct_u232.c')
-rw-r--r-- | drivers/usb/serial/mct_u232.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c index 6804efeb9456..a975bb80303f 100644 --- a/drivers/usb/serial/mct_u232.c +++ b/drivers/usb/serial/mct_u232.c | |||
@@ -482,7 +482,6 @@ static int mct_u232_open(struct tty_struct *tty, struct usb_serial_port *port) | |||
482 | mct_u232_msr_to_state(&priv->control_state, priv->last_msr); | 482 | mct_u232_msr_to_state(&priv->control_state, priv->last_msr); |
483 | spin_unlock_irqrestore(&priv->lock, flags); | 483 | spin_unlock_irqrestore(&priv->lock, flags); |
484 | 484 | ||
485 | port->read_urb->dev = port->serial->dev; | ||
486 | retval = usb_submit_urb(port->read_urb, GFP_KERNEL); | 485 | retval = usb_submit_urb(port->read_urb, GFP_KERNEL); |
487 | if (retval) { | 486 | if (retval) { |
488 | dev_err(&port->dev, | 487 | dev_err(&port->dev, |
@@ -491,7 +490,6 @@ static int mct_u232_open(struct tty_struct *tty, struct usb_serial_port *port) | |||
491 | goto error; | 490 | goto error; |
492 | } | 491 | } |
493 | 492 | ||
494 | port->interrupt_in_urb->dev = port->serial->dev; | ||
495 | retval = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); | 493 | retval = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); |
496 | if (retval) { | 494 | if (retval) { |
497 | usb_kill_urb(port->read_urb); | 495 | usb_kill_urb(port->read_urb); |