diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2006-09-25 06:51:41 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2006-09-28 18:36:43 -0400 |
commit | e81ee637e4aed723f71007c90a901268317ed6d6 (patch) | |
tree | 25fec34b4577eb36b52b8e4e45a191138ac49404 /drivers/usb/serial/keyspan_pda.c | |
parent | 2e3a43f0b6f16705ec76d3744b82a116965ebebe (diff) |
usb-serial: possible irq lock inversion (PPP vs. usb/serial)
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
Diffstat (limited to 'drivers/usb/serial/keyspan_pda.c')
-rw-r--r-- | drivers/usb/serial/keyspan_pda.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspan_pda.c index 49b8dc039d1f..59e777f1e8fd 100644 --- a/drivers/usb/serial/keyspan_pda.c +++ b/drivers/usb/serial/keyspan_pda.c | |||
@@ -518,13 +518,13 @@ static int keyspan_pda_write(struct usb_serial_port *port, | |||
518 | the TX urb is in-flight (wait until it completes) | 518 | the TX urb is in-flight (wait until it completes) |
519 | the device is full (wait until it says there is room) | 519 | the device is full (wait until it says there is room) |
520 | */ | 520 | */ |
521 | spin_lock(&port->lock); | 521 | spin_lock_bh(&port->lock); |
522 | if (port->write_urb_busy || priv->tx_throttled) { | 522 | if (port->write_urb_busy || priv->tx_throttled) { |
523 | spin_unlock(&port->lock); | 523 | spin_unlock_bh(&port->lock); |
524 | return 0; | 524 | return 0; |
525 | } | 525 | } |
526 | port->write_urb_busy = 1; | 526 | port->write_urb_busy = 1; |
527 | spin_unlock(&port->lock); | 527 | spin_unlock_bh(&port->lock); |
528 | 528 | ||
529 | /* At this point the URB is in our control, nobody else can submit it | 529 | /* At this point the URB is in our control, nobody else can submit it |
530 | again (the only sudden transition was the one from EINPROGRESS to | 530 | again (the only sudden transition was the one from EINPROGRESS to |