diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2010-01-21 10:35:43 -0500 | 
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-01-21 10:35:43 -0500 | 
| commit | c9140487b4601ea0b4479af3d92ceb0cda2c691f (patch) | |
| tree | 6ff23dfe9d7366accade95b6aaad9ffd434690d0 /drivers/usb/serial/generic.c | |
| parent | 456eac94789e1b512515e6974e091ef655f343de (diff) | |
| parent | 0a2fea2e0dea9df8ead1cb45e4b9cd68e1b1d29b (diff) | |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6:
  USB: isp1362: fix build failure on ARM systems via irq_flags cleanup
  USB: isp1362: better 64bit printf warning fixes
  USB: fix usbstorage for 2770:915d delivers no FAT
  USB: Fix level of isp1760 Reloading ptd error message
  USB: FHCI: avoid NULL pointer dereference
  USB: Fix duplicate sysfs problem after device reset.
  USB: add speed values for USB 3.0 and wireless controllers
  USB: add missing delay during remote wakeup
  USB: EHCI & UHCI: fix race between root-hub suspend and port resume
  USB: EHCI: fix handling of unusual interrupt intervals
  USB: Don't use GFP_KERNEL while we cannot reset a storage device
  USB: fix bitmask merge error
  usb: serial: fix memory leak in generic driver
  USB: serial: fix USB serial fix kfifo_len locking
Diffstat (limited to 'drivers/usb/serial/generic.c')
| -rw-r--r-- | drivers/usb/serial/generic.c | 10 | 
1 files changed, 6 insertions, 4 deletions
| diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c index f1ea3a33b6e6..83443d6306d6 100644 --- a/drivers/usb/serial/generic.c +++ b/drivers/usb/serial/generic.c | |||
| @@ -386,12 +386,12 @@ int usb_serial_generic_chars_in_buffer(struct tty_struct *tty) | |||
| 386 | 386 | ||
| 387 | dbg("%s - port %d", __func__, port->number); | 387 | dbg("%s - port %d", __func__, port->number); | 
| 388 | 388 | ||
| 389 | if (serial->type->max_in_flight_urbs) { | 389 | spin_lock_irqsave(&port->lock, flags); | 
| 390 | spin_lock_irqsave(&port->lock, flags); | 390 | if (serial->type->max_in_flight_urbs) | 
| 391 | chars = port->tx_bytes_flight; | 391 | chars = port->tx_bytes_flight; | 
| 392 | spin_unlock_irqrestore(&port->lock, flags); | 392 | else if (serial->num_bulk_out) | 
| 393 | } else if (serial->num_bulk_out) | ||
| 394 | chars = kfifo_len(&port->write_fifo); | 393 | chars = kfifo_len(&port->write_fifo); | 
| 394 | spin_unlock_irqrestore(&port->lock, flags); | ||
| 395 | 395 | ||
| 396 | dbg("%s - returns %d", __func__, chars); | 396 | dbg("%s - returns %d", __func__, chars); | 
| 397 | return chars; | 397 | return chars; | 
| @@ -489,6 +489,8 @@ void usb_serial_generic_write_bulk_callback(struct urb *urb) | |||
| 489 | dbg("%s - port %d", __func__, port->number); | 489 | dbg("%s - port %d", __func__, port->number); | 
| 490 | 490 | ||
| 491 | if (port->serial->type->max_in_flight_urbs) { | 491 | if (port->serial->type->max_in_flight_urbs) { | 
| 492 | kfree(urb->transfer_buffer); | ||
| 493 | |||
| 492 | spin_lock_irqsave(&port->lock, flags); | 494 | spin_lock_irqsave(&port->lock, flags); | 
| 493 | --port->urbs_in_flight; | 495 | --port->urbs_in_flight; | 
| 494 | port->tx_bytes_flight -= urb->transfer_buffer_length; | 496 | port->tx_bytes_flight -= urb->transfer_buffer_length; | 
