diff options
author | Jesper Juhl <juhl-lkml@dif.dk> | 2005-04-18 20:39:34 -0400 |
---|---|---|
committer | Greg K-H <gregkh@suse.de> | 2005-04-18 20:39:34 -0400 |
commit | 1bc3c9e1e44c2059fe2ffa6ff70ad0a925d7b05f (patch) | |
tree | 0bc14ec53acf3b4c08a9995c7ea335e236435558 /drivers/usb/serial/empeg.c | |
parent | 6fd19f4b55f7fd1c9d8650bd7f8df2c81b69c5ca (diff) |
[PATCH] USB: kfree cleanup for drivers/usb/* - no need to check for NULL
Get rid of a bunch of redundant NULL pointer checks in drivers/usb/*,
there's no need to check a pointer for NULL before calling kfree() on it.
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Index: gregkh-2.6/drivers/usb/class/audio.c
===================================================================
Diffstat (limited to 'drivers/usb/serial/empeg.c')
-rw-r--r-- | drivers/usb/serial/empeg.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/usb/serial/empeg.c b/drivers/usb/serial/empeg.c index 4d46394f351b..8d562ab454a8 100644 --- a/drivers/usb/serial/empeg.c +++ b/drivers/usb/serial/empeg.c | |||
@@ -550,8 +550,7 @@ failed_usb_register: | |||
550 | failed_usb_serial_register: | 550 | failed_usb_serial_register: |
551 | for (i = 0; i < NUM_URBS; ++i) { | 551 | for (i = 0; i < NUM_URBS; ++i) { |
552 | if (write_urb_pool[i]) { | 552 | if (write_urb_pool[i]) { |
553 | if (write_urb_pool[i]->transfer_buffer) | 553 | kfree(write_urb_pool[i]->transfer_buffer); |
554 | kfree(write_urb_pool[i]->transfer_buffer); | ||
555 | usb_free_urb(write_urb_pool[i]); | 554 | usb_free_urb(write_urb_pool[i]); |
556 | } | 555 | } |
557 | } | 556 | } |
@@ -575,8 +574,7 @@ static void __exit empeg_exit (void) | |||
575 | * the host controllers get fixed to set urb->dev = NULL after | 574 | * the host controllers get fixed to set urb->dev = NULL after |
576 | * the urb is finished. Otherwise this call oopses. */ | 575 | * the urb is finished. Otherwise this call oopses. */ |
577 | /* usb_kill_urb(write_urb_pool[i]); */ | 576 | /* usb_kill_urb(write_urb_pool[i]); */ |
578 | if (write_urb_pool[i]->transfer_buffer) | 577 | kfree(write_urb_pool[i]->transfer_buffer); |
579 | kfree(write_urb_pool[i]->transfer_buffer); | ||
580 | usb_free_urb (write_urb_pool[i]); | 578 | usb_free_urb (write_urb_pool[i]); |
581 | } | 579 | } |
582 | } | 580 | } |