[PATCH] USB: Let usbmon collect less garbage

Alan Stern pointed out that (in 2.6 kernel) one successful submission results
in one callback, even for ISO-out transfers. Thus, the silly check can be
removed from usbmon. This reduces the amount of garbage printed in case
of ISO and Interrupt transfers.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 6 insertions, 13 deletions

diff --git a/drivers/usb/mon/mon_text.c b/drivers/usb/mon/mon_text.c
index 17d0190ef64e..611612146ae9 100644
--- a/drivers/usb/mon/mon_text.c
+++ b/drivers/usb/mon/mon_text.c
@@ -97,19 +97,12 @@ static inline char mon_text_get_data(struct mon_event_text *ep, struct urb *urb,
         if (len >= DATA_MAX)
                 len = DATA_MAX;
 
-        /*
-         * Bulk is easy to shortcut reliably. 
-         * XXX Other pipe types need consideration. Currently, we overdo it
-         * and collect garbage for them: better more than less.
-         */
-        if (usb_pipebulk(pipe) || usb_pipecontrol(pipe)) {
-                if (usb_pipein(pipe)) {
-                        if (ev_type == 'S')
-                                return '<';
-                } else {
-                        if (ev_type == 'C')
-                                return '>';
-                }
+        if (usb_pipein(pipe)) {
+                if (ev_type == 'S')
+                        return '<';
+        } else {
+                if (ev_type == 'C')
+                        return '>';
         }
 
         /*