diff options
author | Oliver Neukum <oliver@neukum.org> | 2010-01-13 09:33:15 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-03-02 17:54:23 -0500 |
commit | 86266452f80545285c14e20a8024f79c4fb88a86 (patch) | |
tree | ebb0a287f9bf189737d4924536d18b36492fd330 /drivers/usb/misc/legousbtower.c | |
parent | f9de332ebf9df71892d52f7eb64af101a647349f (diff) |
USB: Push BKL on open down into the drivers
Straightforward push into the drivers to allow
auditing individual drivers separately
Signed-off-by: Oliver Neukum <oliver@neukum.org>
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/misc/legousbtower.c')
-rw-r--r-- | drivers/usb/misc/legousbtower.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index 3d4378fb4410..94e1b84134dd 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c | |||
@@ -82,6 +82,7 @@ | |||
82 | #include <linux/module.h> | 82 | #include <linux/module.h> |
83 | #include <linux/completion.h> | 83 | #include <linux/completion.h> |
84 | #include <linux/mutex.h> | 84 | #include <linux/mutex.h> |
85 | #include <linux/smp_lock.h> | ||
85 | #include <asm/uaccess.h> | 86 | #include <asm/uaccess.h> |
86 | #include <linux/usb.h> | 87 | #include <linux/usb.h> |
87 | #include <linux/poll.h> | 88 | #include <linux/poll.h> |
@@ -345,6 +346,7 @@ static int tower_open (struct inode *inode, struct file *file) | |||
345 | 346 | ||
346 | dbg(2, "%s: enter", __func__); | 347 | dbg(2, "%s: enter", __func__); |
347 | 348 | ||
349 | lock_kernel(); | ||
348 | nonseekable_open(inode, file); | 350 | nonseekable_open(inode, file); |
349 | subminor = iminor(inode); | 351 | subminor = iminor(inode); |
350 | 352 | ||
@@ -430,6 +432,7 @@ unlock_exit: | |||
430 | mutex_unlock(&dev->lock); | 432 | mutex_unlock(&dev->lock); |
431 | 433 | ||
432 | exit: | 434 | exit: |
435 | unlock_kernel(); | ||
433 | dbg(2, "%s: leave, return value %d ", __func__, retval); | 436 | dbg(2, "%s: leave, return value %d ", __func__, retval); |
434 | 437 | ||
435 | return retval; | 438 | return retval; |