diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2008-08-14 12:37:34 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-10-17 17:41:13 -0400 |
commit | fd3f1917e345d852ef9ae36178719f4e639f70ae (patch) | |
tree | cecafd0b978ede1735aa7e3eb0e032ccf8b63edc /drivers/usb/misc/emi26.c | |
parent | 69a85942ff2df8e1ee0a3b6afe8b1d85dce58333 (diff) |
USB: remove err() macro from usb misc drivers
USB should not be having it's own printk macros, so remove err() and
use the system-wide standard of dev_err() wherever possible. In the
few places that will not work out, use a basic printk().
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/misc/emi26.c')
-rw-r--r-- | drivers/usb/misc/emi26.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/drivers/usb/misc/emi26.c b/drivers/usb/misc/emi26.c index 1ee72055f468..e762beb5f3c6 100644 --- a/drivers/usb/misc/emi26.c +++ b/drivers/usb/misc/emi26.c | |||
@@ -50,7 +50,7 @@ static int emi26_writememory (struct usb_device *dev, int address, | |||
50 | unsigned char *buffer = kmemdup(data, length, GFP_KERNEL); | 50 | unsigned char *buffer = kmemdup(data, length, GFP_KERNEL); |
51 | 51 | ||
52 | if (!buffer) { | 52 | if (!buffer) { |
53 | err("emi26: kmalloc(%d) failed.", length); | 53 | dev_err(&dev->dev, "kmalloc(%d) failed.\n", length); |
54 | return -ENOMEM; | 54 | return -ENOMEM; |
55 | } | 55 | } |
56 | /* Note: usb_control_msg returns negative value on error or length of the | 56 | /* Note: usb_control_msg returns negative value on error or length of the |
@@ -68,7 +68,7 @@ static int emi26_set_reset (struct usb_device *dev, unsigned char reset_bit) | |||
68 | /* printk(KERN_DEBUG "%s - %d", __func__, reset_bit); */ | 68 | /* printk(KERN_DEBUG "%s - %d", __func__, reset_bit); */ |
69 | response = emi26_writememory (dev, CPUCS_REG, &reset_bit, 1, 0xa0); | 69 | response = emi26_writememory (dev, CPUCS_REG, &reset_bit, 1, 0xa0); |
70 | if (response < 0) { | 70 | if (response < 0) { |
71 | err("emi26: set_reset (%d) failed", reset_bit); | 71 | dev_err(&dev->dev, "set_reset (%d) failed\n", reset_bit); |
72 | } | 72 | } |
73 | return response; | 73 | return response; |
74 | } | 74 | } |
@@ -88,7 +88,8 @@ static int emi26_load_firmware (struct usb_device *dev) | |||
88 | 88 | ||
89 | buf = kmalloc(FW_LOAD_SIZE, GFP_KERNEL); | 89 | buf = kmalloc(FW_LOAD_SIZE, GFP_KERNEL); |
90 | if (!buf) { | 90 | if (!buf) { |
91 | err( "%s - error loading firmware: error = %d", __func__, -ENOMEM); | 91 | dev_err(&dev->dev, "%s - error loading firmware: error = %d\n", |
92 | __func__, -ENOMEM); | ||
92 | err = -ENOMEM; | 93 | err = -ENOMEM; |
93 | goto wraperr; | 94 | goto wraperr; |
94 | } | 95 | } |
@@ -106,14 +107,16 @@ static int emi26_load_firmware (struct usb_device *dev) | |||
106 | &dev->dev); | 107 | &dev->dev); |
107 | if (err) { | 108 | if (err) { |
108 | nofw: | 109 | nofw: |
109 | err( "%s - request_firmware() failed", __func__); | 110 | dev_err(&dev->dev, "%s - request_firmware() failed\n", |
111 | __func__); | ||
110 | goto wraperr; | 112 | goto wraperr; |
111 | } | 113 | } |
112 | 114 | ||
113 | /* Assert reset (stop the CPU in the EMI) */ | 115 | /* Assert reset (stop the CPU in the EMI) */ |
114 | err = emi26_set_reset(dev,1); | 116 | err = emi26_set_reset(dev,1); |
115 | if (err < 0) { | 117 | if (err < 0) { |
116 | err( "%s - error loading firmware: error = %d", __func__, err); | 118 | dev_err(&dev->dev,"%s - error loading firmware: error = %d\n", |
119 | __func__, err); | ||
117 | goto wraperr; | 120 | goto wraperr; |
118 | } | 121 | } |
119 | 122 | ||