diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2008-08-14 12:37:34 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-10-17 17:41:13 -0400 |
commit | fd3f1917e345d852ef9ae36178719f4e639f70ae (patch) | |
tree | cecafd0b978ede1735aa7e3eb0e032ccf8b63edc /drivers/usb/misc/adutux.c | |
parent | 69a85942ff2df8e1ee0a3b6afe8b1d85dce58333 (diff) |
USB: remove err() macro from usb misc drivers
USB should not be having it's own printk macros, so remove err() and
use the system-wide standard of dev_err() wherever possible. In the
few places that will not work out, use a basic printk().
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/misc/adutux.c')
-rw-r--r-- | drivers/usb/misc/adutux.c | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index 92f58ccc8fb3..7b6922e08ed1 100644 --- a/drivers/usb/misc/adutux.c +++ b/drivers/usb/misc/adutux.c | |||
@@ -283,8 +283,8 @@ static int adu_open(struct inode *inode, struct file *file) | |||
283 | 283 | ||
284 | interface = usb_find_interface(&adu_driver, subminor); | 284 | interface = usb_find_interface(&adu_driver, subminor); |
285 | if (!interface) { | 285 | if (!interface) { |
286 | err("%s - error, can't find device for minor %d", | 286 | printk(KERN_ERR "adutux: %s - error, can't find device for " |
287 | __func__, subminor); | 287 | "minor %d\n", __func__, subminor); |
288 | retval = -ENODEV; | 288 | retval = -ENODEV; |
289 | goto exit_no_device; | 289 | goto exit_no_device; |
290 | } | 290 | } |
@@ -416,7 +416,8 @@ static ssize_t adu_read(struct file *file, __user char *buffer, size_t count, | |||
416 | /* verify that the device wasn't unplugged */ | 416 | /* verify that the device wasn't unplugged */ |
417 | if (dev->udev == NULL) { | 417 | if (dev->udev == NULL) { |
418 | retval = -ENODEV; | 418 | retval = -ENODEV; |
419 | err("No device or device unplugged %d", retval); | 419 | printk(KERN_ERR "adutux: No device or device unplugged %d\n", |
420 | retval); | ||
420 | goto exit; | 421 | goto exit; |
421 | } | 422 | } |
422 | 423 | ||
@@ -576,7 +577,8 @@ static ssize_t adu_write(struct file *file, const __user char *buffer, | |||
576 | /* verify that the device wasn't unplugged */ | 577 | /* verify that the device wasn't unplugged */ |
577 | if (dev->udev == NULL) { | 578 | if (dev->udev == NULL) { |
578 | retval = -ENODEV; | 579 | retval = -ENODEV; |
579 | err("No device or device unplugged %d", retval); | 580 | printk(KERN_ERR "adutux: No device or device unplugged %d\n", |
581 | retval); | ||
580 | goto exit; | 582 | goto exit; |
581 | } | 583 | } |
582 | 584 | ||
@@ -645,7 +647,8 @@ static ssize_t adu_write(struct file *file, const __user char *buffer, | |||
645 | retval = usb_submit_urb(dev->interrupt_out_urb, GFP_KERNEL); | 647 | retval = usb_submit_urb(dev->interrupt_out_urb, GFP_KERNEL); |
646 | if (retval < 0) { | 648 | if (retval < 0) { |
647 | dev->out_urb_finished = 1; | 649 | dev->out_urb_finished = 1; |
648 | err("Couldn't submit interrupt_out_urb %d", retval); | 650 | dev_err(&dev->udev->dev, "Couldn't submit " |
651 | "interrupt_out_urb %d\n", retval); | ||
649 | goto exit; | 652 | goto exit; |
650 | } | 653 | } |
651 | 654 | ||
@@ -890,8 +893,8 @@ static int __init adu_init(void) | |||
890 | /* register this driver with the USB subsystem */ | 893 | /* register this driver with the USB subsystem */ |
891 | result = usb_register(&adu_driver); | 894 | result = usb_register(&adu_driver); |
892 | if (result < 0) { | 895 | if (result < 0) { |
893 | err("usb_register failed for the "__FILE__" driver. " | 896 | printk(KERN_ERR "usb_register failed for the "__FILE__ |
894 | "Error number %d", result); | 897 | " driver. Error number %d\n", result); |
895 | goto exit; | 898 | goto exit; |
896 | } | 899 | } |
897 | 900 | ||