[PATCH] Generic HID layer - USB API

- 'dev' in struct hid_device changed from struct usb_device to
  struct device and fixed all the users
- renamed functions which are part of USB HID API from 'hid_*' to
  'usbhid_*'
- force feedback initialization moved from common part into USB-specific
  driver
- added usbhid.h header for USB HID API users
- removed USB-specific fields from struct hid_device and moved them
  to new usbhid_device, which is pointed to by hid_device->driver_data
- fixed all USB users to use this new structure

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 17 insertions, 14 deletions

diff --git a/drivers/usb/input/hiddev.c b/drivers/usb/input/hiddev.c
index 07d7996575cd..0c2647eb9eec 100644
--- a/drivers/usb/input/hiddev.c
+++ b/drivers/usb/input/hiddev.c
@@ -240,7 +240,7 @@ static int hiddev_release(struct inode * inode, struct file * file)
 
         if (!--list->hiddev->open) {
                 if (list->hiddev->exist)
-                        hid_close(list->hiddev->hid);
+                        usbhid_close(list->hiddev->hid);
                 else
                         kfree(list->hiddev);
         }
@@ -271,7 +271,7 @@ static int hiddev_open(struct inode *inode, struct file *file)
 
         if (!list->hiddev->open++)
                 if (list->hiddev->exist)
-                        hid_open(hiddev_table[i]->hid);
+                        usbhid_open(hiddev_table[i]->hid);
 
         return 0;
 }
@@ -383,7 +383,7 @@ static int hiddev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
         struct hiddev_list *list = file->private_data;
         struct hiddev *hiddev = list->hiddev;
         struct hid_device *hid = hiddev->hid;
-        struct usb_device *dev = hid->dev;
+        struct usb_device *dev = to_usb_device(hid->dev);
         struct hiddev_collection_info cinfo;
         struct hiddev_report_info rinfo;
         struct hiddev_field_info finfo;
@@ -392,6 +392,7 @@ static int hiddev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
         struct hiddev_devinfo dinfo;
         struct hid_report *report;
         struct hid_field *field;
+        struct usbhid_device *usbhid = hid->driver_data;
         void __user *user_arg = (void __user *)arg;
         int i;
 
@@ -421,7 +422,7 @@ static int hiddev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
                 dinfo.bustype = BUS_USB;
                 dinfo.busnum = dev->bus->busnum;
                 dinfo.devnum = dev->devnum;
-                dinfo.ifnum = hid->ifnum;
+                dinfo.ifnum = usbhid->ifnum;
                 dinfo.vendor = le16_to_cpu(dev->descriptor.idVendor);
                 dinfo.product = le16_to_cpu(dev->descriptor.idProduct);
                 dinfo.version = le16_to_cpu(dev->descriptor.bcdDevice);
@@ -480,7 +481,7 @@ static int hiddev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
                 }
 
         case HIDIOCINITREPORT:
-                hid_init_reports(hid);
+                usbhid_init_reports(hid);
 
                 return 0;
 
@@ -494,8 +495,8 @@ static int hiddev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
                 if ((report = hiddev_lookup_report(hid, &rinfo)) == NULL)
                         return -EINVAL;
 
-                hid_submit_report(hid, report, USB_DIR_IN);
-                hid_wait_io(hid);
+                usbhid_submit_report(hid, report, USB_DIR_IN);
+                usbhid_wait_io(hid);
 
                 return 0;
 
@@ -509,8 +510,8 @@ static int hiddev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
                 if ((report = hiddev_lookup_report(hid, &rinfo)) == NULL)
                         return -EINVAL;
 
-                hid_submit_report(hid, report, USB_DIR_OUT);
-                hid_wait_io(hid);
+                usbhid_submit_report(hid, report, USB_DIR_OUT);
+                usbhid_wait_io(hid);
 
                 return 0;
 
@@ -746,6 +747,7 @@ static struct usb_class_driver hiddev_class = {
 int hiddev_connect(struct hid_device *hid)
 {
         struct hiddev *hiddev;
+        struct usbhid_device *usbhid = hid->driver_data;
         int i;
         int retval;
 
@@ -761,7 +763,7 @@ int hiddev_connect(struct hid_device *hid)
         if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL)))
                 return -1;
 
-        retval = usb_register_dev(hid->intf, &hiddev_class);
+        retval = usb_register_dev(usbhid->intf, &hiddev_class);
         if (retval) {
                 err("Not able to get a minor for this device.");
                 kfree(hiddev);
@@ -773,10 +775,10 @@ int hiddev_connect(struct hid_device *hid)
         hiddev->hid = hid;
         hiddev->exist = 1;
 
-        hid->minor = hid->intf->minor;
+        hid->minor = usbhid->intf->minor;
         hid->hiddev = hiddev;
 
-        hiddev_table[hid->intf->minor - HIDDEV_MINOR_BASE] = hiddev;
+        hiddev_table[usbhid->intf->minor - HIDDEV_MINOR_BASE] = hiddev;
 
         return 0;
 }
@@ -789,14 +791,15 @@ static struct usb_class_driver hiddev_class;
 void hiddev_disconnect(struct hid_device *hid)
 {
         struct hiddev *hiddev = hid->hiddev;
+        struct usbhid_device *usbhid = hid->driver_data;
 
         hiddev->exist = 0;
 
         hiddev_table[hiddev->hid->minor - HIDDEV_MINOR_BASE] = NULL;
-        usb_deregister_dev(hiddev->hid->intf, &hiddev_class);
+        usb_deregister_dev(usbhid->intf, &hiddev_class);
 
         if (hiddev->open) {
-                hid_close(hiddev->hid);
+                usbhid_close(hiddev->hid);
                 wake_up_interruptible(&hiddev->wait);
         } else {
                 kfree(hiddev);