diff options
author | Németh Márton <nm127@freemail.hu> | 2010-01-10 09:34:36 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-03-02 17:54:17 -0500 |
commit | 9052127f631c8d71d5149da08d48014283faff2f (patch) | |
tree | d3470617c8c7dfbc371523df45a63b54a1f8f94c /drivers/usb/image | |
parent | 7d40d7e85a25e01948bcb4dc3eda1355af318337 (diff) |
USB image: make USB device id constant
The id_table field of the struct usb_device_id is constant in <linux/usb.h>
so it is worth to make the initialization data also constant.
The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
struct I1 {
...
const struct I2 *x;
...
};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
struct I1 y = {
.x = E,
};
@c@
identifier r.I2;
identifier s.E;
@@
const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const
struct I2 E[] = ...;
// </smpl>
Signed-off-by: Németh Márton <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/image')
-rw-r--r-- | drivers/usb/image/mdc800.c | 2 | ||||
-rw-r--r-- | drivers/usb/image/microtek.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/drivers/usb/image/mdc800.c b/drivers/usb/image/mdc800.c index eca355dccf65..e192e8f7c560 100644 --- a/drivers/usb/image/mdc800.c +++ b/drivers/usb/image/mdc800.c | |||
@@ -967,7 +967,7 @@ static const struct file_operations mdc800_device_ops = | |||
967 | 967 | ||
968 | 968 | ||
969 | 969 | ||
970 | static struct usb_device_id mdc800_table [] = { | 970 | static const struct usb_device_id mdc800_table[] = { |
971 | { USB_DEVICE(MDC800_VENDOR_ID, MDC800_PRODUCT_ID) }, | 971 | { USB_DEVICE(MDC800_VENDOR_ID, MDC800_PRODUCT_ID) }, |
972 | { } /* Terminating entry */ | 972 | { } /* Terminating entry */ |
973 | }; | 973 | }; |
diff --git a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c index 459a7287fe01..3a6bcd5fee09 100644 --- a/drivers/usb/image/microtek.c +++ b/drivers/usb/image/microtek.c | |||
@@ -155,7 +155,7 @@ static int mts_usb_probe(struct usb_interface *intf, | |||
155 | const struct usb_device_id *id); | 155 | const struct usb_device_id *id); |
156 | static void mts_usb_disconnect(struct usb_interface *intf); | 156 | static void mts_usb_disconnect(struct usb_interface *intf); |
157 | 157 | ||
158 | static struct usb_device_id mts_usb_ids []; | 158 | static const struct usb_device_id mts_usb_ids[]; |
159 | 159 | ||
160 | static struct usb_driver mts_usb_driver = { | 160 | static struct usb_driver mts_usb_driver = { |
161 | .name = "microtekX6", | 161 | .name = "microtekX6", |
@@ -656,7 +656,7 @@ static struct scsi_host_template mts_scsi_host_template = { | |||
656 | /* The entries of microtek_table must correspond, line-by-line to | 656 | /* The entries of microtek_table must correspond, line-by-line to |
657 | the entries of mts_supported_products[]. */ | 657 | the entries of mts_supported_products[]. */ |
658 | 658 | ||
659 | static struct usb_device_id mts_usb_ids [] = | 659 | static const struct usb_device_id mts_usb_ids[] = |
660 | { | 660 | { |
661 | { USB_DEVICE(0x4ce, 0x0300) }, | 661 | { USB_DEVICE(0x4ce, 0x0300) }, |
662 | { USB_DEVICE(0x5da, 0x0094) }, | 662 | { USB_DEVICE(0x5da, 0x0094) }, |