aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/host
diff options
context:
space:
mode:
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>2007-12-06 16:29:46 -0500
committerGreg Kroah-Hartman <gregkh@suse.de>2008-02-01 17:34:53 -0500
commitbadef819229d455493ba97253dd0e4097b995624 (patch)
tree9fd48d52b67ff35ddb6364474d4f81d3c7b8b216 /drivers/usb/host
parent694cc2087e26f3f62b9f07c5d563564ed77ef203 (diff)
usb: Remove OHCI useless masking/unmasking of WDH interrupt
The OHCI driver's IRQ handler, while processing a WDH interrupt, masks and unmasks it. I believe this is both broken (the write may still be posted during the donelist processing it's trying to safeguard) and useless as this IRQ may not be reissued until it's acked (unless this legacy code is an uncommented workaround for some chip erratum). Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/host')
-rw-r--r--drivers/usb/host/ohci-hcd.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
index baca09af6076..8dd5d25f2f06 100644
--- a/drivers/usb/host/ohci-hcd.c
+++ b/drivers/usb/host/ohci-hcd.c
@@ -810,13 +810,9 @@ static irqreturn_t ohci_irq (struct usb_hcd *hcd)
810 } 810 }
811 811
812 if (ints & OHCI_INTR_WDH) { 812 if (ints & OHCI_INTR_WDH) {
813 if (HC_IS_RUNNING(hcd->state))
814 ohci_writel (ohci, OHCI_INTR_WDH, &regs->intrdisable);
815 spin_lock (&ohci->lock); 813 spin_lock (&ohci->lock);
816 dl_done_list (ohci); 814 dl_done_list (ohci);
817 spin_unlock (&ohci->lock); 815 spin_unlock (&ohci->lock);
818 if (HC_IS_RUNNING(hcd->state))
819 ohci_writel (ohci, OHCI_INTR_WDH, &regs->intrenable);
820 } 816 }
821 817
822 if (quirk_zfmicro(ohci) && (ints & OHCI_INTR_SF)) { 818 if (quirk_zfmicro(ohci) && (ints & OHCI_INTR_SF)) {