diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
commit | 90ab5ee94171b3e28de6bb42ee30b527014e0be7 (patch) | |
tree | fcf89889f6e881f2b231d3d20287c08174ce4b54 /drivers/usb/host | |
parent | 476bc0015bf09dad39d36a8b19f76f0c181d1ec9 (diff) |
module_param: make bool parameters really bool (drivers & misc)
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.
It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/usb/host')
-rw-r--r-- | drivers/usb/host/ehci-hcd.c | 2 | ||||
-rw-r--r-- | drivers/usb/host/ohci-hcd.c | 4 | ||||
-rw-r--r-- | drivers/usb/host/oxu210hp-hcd.c | 2 | ||||
-rw-r--r-- | drivers/usb/host/u132-hcd.c | 2 | ||||
-rw-r--r-- | drivers/usb/host/uhci-hcd.c | 2 |
5 files changed, 6 insertions, 6 deletions
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index e311a511529b..a007a9fe0f87 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c | |||
@@ -112,7 +112,7 @@ module_param (park, uint, S_IRUGO); | |||
112 | MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets"); | 112 | MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets"); |
113 | 113 | ||
114 | /* for flakey hardware, ignore overcurrent indicators */ | 114 | /* for flakey hardware, ignore overcurrent indicators */ |
115 | static int ignore_oc = 0; | 115 | static bool ignore_oc = 0; |
116 | module_param (ignore_oc, bool, S_IRUGO); | 116 | module_param (ignore_oc, bool, S_IRUGO); |
117 | MODULE_PARM_DESC (ignore_oc, "ignore bogus hardware overcurrent indications"); | 117 | MODULE_PARM_DESC (ignore_oc, "ignore bogus hardware overcurrent indications"); |
118 | 118 | ||
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index 5f5a63241436..34b9edd86651 100644 --- a/drivers/usb/host/ohci-hcd.c +++ b/drivers/usb/host/ohci-hcd.c | |||
@@ -115,13 +115,13 @@ static inline void sb800_prefetch(struct ohci_hcd *ohci, int on) | |||
115 | 115 | ||
116 | 116 | ||
117 | /* Some boards misreport power switching/overcurrent */ | 117 | /* Some boards misreport power switching/overcurrent */ |
118 | static int distrust_firmware = 1; | 118 | static bool distrust_firmware = 1; |
119 | module_param (distrust_firmware, bool, 0); | 119 | module_param (distrust_firmware, bool, 0); |
120 | MODULE_PARM_DESC (distrust_firmware, | 120 | MODULE_PARM_DESC (distrust_firmware, |
121 | "true to distrust firmware power/overcurrent setup"); | 121 | "true to distrust firmware power/overcurrent setup"); |
122 | 122 | ||
123 | /* Some boards leave IR set wrongly, since they fail BIOS/SMM handshakes */ | 123 | /* Some boards leave IR set wrongly, since they fail BIOS/SMM handshakes */ |
124 | static int no_handshake = 0; | 124 | static bool no_handshake = 0; |
125 | module_param (no_handshake, bool, 0); | 125 | module_param (no_handshake, bool, 0); |
126 | MODULE_PARM_DESC (no_handshake, "true (not default) disables BIOS handshake"); | 126 | MODULE_PARM_DESC (no_handshake, "true (not default) disables BIOS handshake"); |
127 | 127 | ||
diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c index 6f62de5c6e35..015c7c62ed49 100644 --- a/drivers/usb/host/oxu210hp-hcd.c +++ b/drivers/usb/host/oxu210hp-hcd.c | |||
@@ -233,7 +233,7 @@ module_param(park, uint, S_IRUGO); | |||
233 | MODULE_PARM_DESC(park, "park setting; 1-3 back-to-back async packets"); | 233 | MODULE_PARM_DESC(park, "park setting; 1-3 back-to-back async packets"); |
234 | 234 | ||
235 | /* For flakey hardware, ignore overcurrent indicators */ | 235 | /* For flakey hardware, ignore overcurrent indicators */ |
236 | static int ignore_oc; | 236 | static bool ignore_oc; |
237 | module_param(ignore_oc, bool, S_IRUGO); | 237 | module_param(ignore_oc, bool, S_IRUGO); |
238 | MODULE_PARM_DESC(ignore_oc, "ignore bogus hardware overcurrent indications"); | 238 | MODULE_PARM_DESC(ignore_oc, "ignore bogus hardware overcurrent indications"); |
239 | 239 | ||
diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c index 533d12cca371..16dd6a6abf00 100644 --- a/drivers/usb/host/u132-hcd.c +++ b/drivers/usb/host/u132-hcd.c | |||
@@ -74,7 +74,7 @@ MODULE_LICENSE("GPL"); | |||
74 | #define INT_MODULE_PARM(n, v) static int n = v;module_param(n, int, 0444) | 74 | #define INT_MODULE_PARM(n, v) static int n = v;module_param(n, int, 0444) |
75 | INT_MODULE_PARM(testing, 0); | 75 | INT_MODULE_PARM(testing, 0); |
76 | /* Some boards misreport power switching/overcurrent*/ | 76 | /* Some boards misreport power switching/overcurrent*/ |
77 | static int distrust_firmware = 1; | 77 | static bool distrust_firmware = 1; |
78 | module_param(distrust_firmware, bool, 0); | 78 | module_param(distrust_firmware, bool, 0); |
79 | MODULE_PARM_DESC(distrust_firmware, "true to distrust firmware power/overcurren" | 79 | MODULE_PARM_DESC(distrust_firmware, "true to distrust firmware power/overcurren" |
80 | "t setup"); | 80 | "t setup"); |
diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c index c8ae199cfbb8..6b5eb1017e2c 100644 --- a/drivers/usb/host/uhci-hcd.c +++ b/drivers/usb/host/uhci-hcd.c | |||
@@ -59,7 +59,7 @@ | |||
59 | #define DRIVER_DESC "USB Universal Host Controller Interface driver" | 59 | #define DRIVER_DESC "USB Universal Host Controller Interface driver" |
60 | 60 | ||
61 | /* for flakey hardware, ignore overcurrent indicators */ | 61 | /* for flakey hardware, ignore overcurrent indicators */ |
62 | static int ignore_oc; | 62 | static bool ignore_oc; |
63 | module_param(ignore_oc, bool, S_IRUGO); | 63 | module_param(ignore_oc, bool, S_IRUGO); |
64 | MODULE_PARM_DESC(ignore_oc, "ignore hardware overcurrent indications"); | 64 | MODULE_PARM_DESC(ignore_oc, "ignore hardware overcurrent indications"); |
65 | 65 | ||