diff options
author | Theodore Ts'o <tytso@mit.edu> | 2006-09-27 04:50:46 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-27 11:26:17 -0400 |
commit | 8e18e2941c53416aa219708e7dcad21fb4bd6794 (patch) | |
tree | 44118f8b09556193ac93e0b71aecfa3e1d4bc182 /drivers/usb/host | |
parent | 6a1d9805ec506d8b9d04450997707da5f643d87c (diff) |
[PATCH] inode_diet: Replace inode.u.generic_ip with inode.i_private
The following patches reduce the size of the VFS inode structure by 28 bytes
on a UP x86. (It would be more on an x86_64 system). This is a 10% reduction
in the inode size on a UP kernel that is configured in a production mode
(i.e., with no spinlock or other debugging functions enabled; if you want to
save memory taken up by in-core inodes, the first thing you should do is
disable the debugging options; they are responsible for a huge amount of bloat
in the VFS inode structure).
This patch:
The filesystem or device-specific pointer in the inode is inside a union,
which is pretty pointless given that all 30+ users of this field have been
using the void pointer. Get rid of the union and rename it to i_private, with
a comment to explain who is allowed to use the void pointer. This is just a
cleanup, but it allows us to reuse the union 'u' for something something where
the union will actually be used.
[judith@osdl.org: powerpc build fix]
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Judith Lebzelter <judith@osdl.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/usb/host')
-rw-r--r-- | drivers/usb/host/isp116x-hcd.c | 2 | ||||
-rw-r--r-- | drivers/usb/host/uhci-debug.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index 5147ed4a6662..8c6b38a0b5bb 100644 --- a/drivers/usb/host/isp116x-hcd.c +++ b/drivers/usb/host/isp116x-hcd.c | |||
@@ -1204,7 +1204,7 @@ static int isp116x_show_dbg(struct seq_file *s, void *unused) | |||
1204 | 1204 | ||
1205 | static int isp116x_open_seq(struct inode *inode, struct file *file) | 1205 | static int isp116x_open_seq(struct inode *inode, struct file *file) |
1206 | { | 1206 | { |
1207 | return single_open(file, isp116x_show_dbg, inode->u.generic_ip); | 1207 | return single_open(file, isp116x_show_dbg, inode->i_private); |
1208 | } | 1208 | } |
1209 | 1209 | ||
1210 | static struct file_operations isp116x_debug_fops = { | 1210 | static struct file_operations isp116x_debug_fops = { |
diff --git a/drivers/usb/host/uhci-debug.c b/drivers/usb/host/uhci-debug.c index dc286a48cafd..d1372cb27f33 100644 --- a/drivers/usb/host/uhci-debug.c +++ b/drivers/usb/host/uhci-debug.c | |||
@@ -428,7 +428,7 @@ struct uhci_debug { | |||
428 | 428 | ||
429 | static int uhci_debug_open(struct inode *inode, struct file *file) | 429 | static int uhci_debug_open(struct inode *inode, struct file *file) |
430 | { | 430 | { |
431 | struct uhci_hcd *uhci = inode->u.generic_ip; | 431 | struct uhci_hcd *uhci = inode->i_private; |
432 | struct uhci_debug *up; | 432 | struct uhci_debug *up; |
433 | int ret = -ENOMEM; | 433 | int ret = -ENOMEM; |
434 | unsigned long flags; | 434 | unsigned long flags; |