aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/host/xhci-ring.c
diff options
context:
space:
mode:
authorOliver Neukum <oneukum@suse.de>2014-01-08 11:13:11 -0500
committerSarah Sharp <sarah.a.sharp@linux.intel.com>2014-03-04 18:38:00 -0500
commite587b8b270d3706147c806d42cc4ac78232caac7 (patch)
tree63ab7cff492b92dc2e12453249ffe721c8479e52 /drivers/usb/host/xhci-ring.c
parent25cd2882e2fc8bd8ed7acaee0ec979f11feda6d7 (diff)
xhci: make warnings greppable
This changes debug messages and warnings in xhci-ring.c to be on a single line so grep can find them. grep must have precedence over the 80 column limit. [Sarah fixed two checkpatch.pl issues with split lines introduced by this commit.] Signed-off-by: Oliver Neukum <oneukum@suse.de> Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Diffstat (limited to 'drivers/usb/host/xhci-ring.c')
-rw-r--r--drivers/usb/host/xhci-ring.c21
1 files changed, 8 insertions, 13 deletions
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 0ed64eb68e48..3ec1d8fe06fa 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -1082,8 +1082,7 @@ static void xhci_handle_cmd_set_deq(struct xhci_hcd *xhci, int slot_id,
1082 1082
1083 ep_ring = xhci_stream_id_to_ring(dev, ep_index, stream_id); 1083 ep_ring = xhci_stream_id_to_ring(dev, ep_index, stream_id);
1084 if (!ep_ring) { 1084 if (!ep_ring) {
1085 xhci_warn(xhci, "WARN Set TR deq ptr command for " 1085 xhci_warn(xhci, "WARN Set TR deq ptr command for freed stream ID %u\n",
1086 "freed stream ID %u\n",
1087 stream_id); 1086 stream_id);
1088 /* XXX: Harmless??? */ 1087 /* XXX: Harmless??? */
1089 dev->eps[ep_index].ep_state &= ~SET_DEQ_PENDING; 1088 dev->eps[ep_index].ep_state &= ~SET_DEQ_PENDING;
@@ -1099,12 +1098,10 @@ static void xhci_handle_cmd_set_deq(struct xhci_hcd *xhci, int slot_id,
1099 1098
1100 switch (cmd_comp_code) { 1099 switch (cmd_comp_code) {
1101 case COMP_TRB_ERR: 1100 case COMP_TRB_ERR:
1102 xhci_warn(xhci, "WARN Set TR Deq Ptr cmd invalid because " 1101 xhci_warn(xhci, "WARN Set TR Deq Ptr cmd invalid because of stream ID configuration\n");
1103 "of stream ID configuration\n");
1104 break; 1102 break;
1105 case COMP_CTX_STATE: 1103 case COMP_CTX_STATE:
1106 xhci_warn(xhci, "WARN Set TR Deq Ptr cmd failed due " 1104 xhci_warn(xhci, "WARN Set TR Deq Ptr cmd failed due to incorrect slot or ep state.\n");
1107 "to incorrect slot or ep state.\n");
1108 ep_state = le32_to_cpu(ep_ctx->ep_info); 1105 ep_state = le32_to_cpu(ep_ctx->ep_info);
1109 ep_state &= EP_STATE_MASK; 1106 ep_state &= EP_STATE_MASK;
1110 slot_state = le32_to_cpu(slot_ctx->dev_state); 1107 slot_state = le32_to_cpu(slot_ctx->dev_state);
@@ -1114,13 +1111,12 @@ static void xhci_handle_cmd_set_deq(struct xhci_hcd *xhci, int slot_id,
1114 slot_state, ep_state); 1111 slot_state, ep_state);
1115 break; 1112 break;
1116 case COMP_EBADSLT: 1113 case COMP_EBADSLT:
1117 xhci_warn(xhci, "WARN Set TR Deq Ptr cmd failed because " 1114 xhci_warn(xhci, "WARN Set TR Deq Ptr cmd failed because slot %u was not enabled.\n",
1118 "slot %u was not enabled.\n", slot_id); 1115 slot_id);
1119 break; 1116 break;
1120 default: 1117 default:
1121 xhci_warn(xhci, "WARN Set TR Deq Ptr cmd with unknown " 1118 xhci_warn(xhci, "WARN Set TR Deq Ptr cmd with unknown completion code of %u.\n",
1122 "completion code of %u.\n", 1119 cmd_comp_code);
1123 cmd_comp_code);
1124 break; 1120 break;
1125 } 1121 }
1126 /* OK what do we do now? The endpoint state is hosed, and we 1122 /* OK what do we do now? The endpoint state is hosed, and we
@@ -1142,8 +1138,7 @@ static void xhci_handle_cmd_set_deq(struct xhci_hcd *xhci, int slot_id,
1142 update_ring_for_set_deq_completion(xhci, dev, 1138 update_ring_for_set_deq_completion(xhci, dev,
1143 ep_ring, ep_index); 1139 ep_ring, ep_index);
1144 } else { 1140 } else {
1145 xhci_warn(xhci, "Mismatch between completed Set TR Deq " 1141 xhci_warn(xhci, "Mismatch between completed Set TR Deq Ptr command & xHCI internal state.\n");
1146 "Ptr command & xHCI internal state.\n");
1147 xhci_warn(xhci, "ep deq seg = %p, deq ptr = %p\n", 1142 xhci_warn(xhci, "ep deq seg = %p, deq ptr = %p\n",
1148 dev->eps[ep_index].queued_deq_seg, 1143 dev->eps[ep_index].queued_deq_seg,
1149 dev->eps[ep_index].queued_deq_ptr); 1144 dev->eps[ep_index].queued_deq_ptr);