diff options
author | Alan Stern <stern@rowland.harvard.edu> | 2005-09-16 14:17:45 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-10-28 19:47:39 -0400 |
commit | 8b4cd42134fbd3c9a9a5c3467d31717798219b1b (patch) | |
tree | aec7570ecc2f481b2a3357f05810be8c3d897669 /drivers/usb/host/uhci-q.c | |
parent | e08fb39b771dd7dcba405669b5384fe9929e1caf (diff) |
[PATCH] USB: UHCI: Remove unused fields and unneeded tests for NULL
This patch (as562) removes from the uhci-hcd driver a few unused fields
and some unnecessary tests against NULL and assignments to NULL. In fact
it wasn't until fairly recently that the tests became unnecessary.
Before last winter it was possible that the driver's stop() routine would
get called even if the start() routine returned an error, but now that
can't happen. Hence there's no longer any need to check for partial
initialization.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/host/uhci-q.c')
-rw-r--r-- | drivers/usb/host/uhci-q.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/usb/host/uhci-q.c b/drivers/usb/host/uhci-q.c index 4e0fbe2c1a9a..d54038211ca6 100644 --- a/drivers/usb/host/uhci-q.c +++ b/drivers/usb/host/uhci-q.c | |||
@@ -443,7 +443,6 @@ static struct urb_priv *uhci_alloc_urb_priv(struct uhci_hcd *uhci, struct urb *u | |||
443 | 443 | ||
444 | memset((void *)urbp, 0, sizeof(*urbp)); | 444 | memset((void *)urbp, 0, sizeof(*urbp)); |
445 | 445 | ||
446 | urbp->inserttime = jiffies; | ||
447 | urbp->fsbrtime = jiffies; | 446 | urbp->fsbrtime = jiffies; |
448 | urbp->urb = urb; | 447 | urbp->urb = urb; |
449 | 448 | ||
@@ -462,8 +461,6 @@ static void uhci_add_td_to_urb(struct urb *urb, struct uhci_td *td) | |||
462 | { | 461 | { |
463 | struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv; | 462 | struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv; |
464 | 463 | ||
465 | td->urb = urb; | ||
466 | |||
467 | list_add_tail(&td->list, &urbp->td_list); | 464 | list_add_tail(&td->list, &urbp->td_list); |
468 | } | 465 | } |
469 | 466 | ||
@@ -473,8 +470,6 @@ static void uhci_remove_td_from_urb(struct uhci_td *td) | |||
473 | return; | 470 | return; |
474 | 471 | ||
475 | list_del_init(&td->list); | 472 | list_del_init(&td->list); |
476 | |||
477 | td->urb = NULL; | ||
478 | } | 473 | } |
479 | 474 | ||
480 | static void uhci_destroy_urb_priv(struct uhci_hcd *uhci, struct urb *urb) | 475 | static void uhci_destroy_urb_priv(struct uhci_hcd *uhci, struct urb *urb) |