diff options
author | Jan Andersson <jan@gaisler.com> | 2011-05-06 06:00:14 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-05-06 21:24:00 -0400 |
commit | e4d235d800c8d75750a46331298e3473c10651b2 (patch) | |
tree | e0ad24c1cc82ac2797837dc32990ac082e515443 /drivers/usb/host/uhci-hcd.c | |
parent | e7652e1ebc0f5e07929067ece14ca869dad20dd6 (diff) |
USB: UHCI: Codingstyle fixes
This patch is part of a series that extend the UHCI HCD to support
non-PCI host controllers.
This patch fixes the following warnings from checkpatch:
ERROR: switch and case should be at the same indent
+ switch (to_pci_dev(uhci_dev(uhci))->vendor) {
+ default:
[...]
+ case PCI_VENDOR_ID_GENESYS:
[...]
+ case PCI_VENDOR_ID_INTEL:
WARNING: static char array declaration should probably be static const char
+ static char bad_Asus_board[] = "A7V8X";
WARNING: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id
+static const struct pci_device_id uhci_pci_ids[] = { {
Signed-off-by: Jan Andersson <jan@gaisler.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/host/uhci-hcd.c')
-rw-r--r-- | drivers/usb/host/uhci-hcd.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c index 683e87e49a03..348174fdfaee 100644 --- a/drivers/usb/host/uhci-hcd.c +++ b/drivers/usb/host/uhci-hcd.c | |||
@@ -226,16 +226,16 @@ static int uhci_pci_resume_detect_interrupts_are_broken(struct uhci_hcd *uhci) | |||
226 | int port; | 226 | int port; |
227 | 227 | ||
228 | switch (to_pci_dev(uhci_dev(uhci))->vendor) { | 228 | switch (to_pci_dev(uhci_dev(uhci))->vendor) { |
229 | default: | 229 | default: |
230 | break; | 230 | break; |
231 | 231 | ||
232 | case PCI_VENDOR_ID_GENESYS: | 232 | case PCI_VENDOR_ID_GENESYS: |
233 | /* Genesys Logic's GL880S controllers don't generate | 233 | /* Genesys Logic's GL880S controllers don't generate |
234 | * resume-detect interrupts. | 234 | * resume-detect interrupts. |
235 | */ | 235 | */ |
236 | return 1; | 236 | return 1; |
237 | 237 | ||
238 | case PCI_VENDOR_ID_INTEL: | 238 | case PCI_VENDOR_ID_INTEL: |
239 | /* Some of Intel's USB controllers have a bug that causes | 239 | /* Some of Intel's USB controllers have a bug that causes |
240 | * resume-detect interrupts if any port has an over-current | 240 | * resume-detect interrupts if any port has an over-current |
241 | * condition. To make matters worse, some motherboards | 241 | * condition. To make matters worse, some motherboards |
@@ -268,7 +268,7 @@ static int uhci_pci_global_suspend_mode_is_broken(struct uhci_hcd *uhci) | |||
268 | { | 268 | { |
269 | int port; | 269 | int port; |
270 | const char *sys_info; | 270 | const char *sys_info; |
271 | static char bad_Asus_board[] = "A7V8X"; | 271 | static const char bad_Asus_board[] = "A7V8X"; |
272 | 272 | ||
273 | /* One of Asus's motherboards has a bug which causes it to | 273 | /* One of Asus's motherboards has a bug which causes it to |
274 | * wake up immediately from suspend-to-RAM if any of the ports | 274 | * wake up immediately from suspend-to-RAM if any of the ports |
@@ -998,7 +998,7 @@ static const struct hc_driver uhci_driver = { | |||
998 | .hub_control = uhci_hub_control, | 998 | .hub_control = uhci_hub_control, |
999 | }; | 999 | }; |
1000 | 1000 | ||
1001 | static const struct pci_device_id uhci_pci_ids[] = { { | 1001 | static DEFINE_PCI_DEVICE_TABLE(uhci_pci_ids) = { { |
1002 | /* handle any USB UHCI controller */ | 1002 | /* handle any USB UHCI controller */ |
1003 | PCI_DEVICE_CLASS(PCI_CLASS_SERIAL_USB_UHCI, ~0), | 1003 | PCI_DEVICE_CLASS(PCI_CLASS_SERIAL_USB_UHCI, ~0), |
1004 | .driver_data = (unsigned long) &uhci_driver, | 1004 | .driver_data = (unsigned long) &uhci_driver, |