aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/host/uhci-hcd.c
diff options
context:
space:
mode:
authorAlan Stern <stern@rowland.harvard.edu>2005-04-25 11:14:31 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2005-06-27 17:43:48 -0400
commit2532178a68b5ce4e421d50ea1b1dcc0a1359f19d (patch)
tree8ceb32dab2f43431946ef9b09fd02cb07e76e4ed /drivers/usb/host/uhci-hcd.c
parent7d35b9298539d2818c51fe9070b08cf9876016f4 (diff)
[PATCH] UHCI: Don't store device pointer in QH or TD
This patch simplifies the uhci-hcd driver by removing the device pointer currently stored in the QH and TD structures. Those pointers weren't being used for anything other than to increment the device's reference count, which is unnecessary since the device is used only when an URB completes, and outstanding URBs take their own reference to the device. As a useful side effect, this change means that uhci-hcd no longer needs to have the root-hub device available in the start routine. Signed-off-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/host/uhci-hcd.c')
-rw-r--r--drivers/usb/host/uhci-hcd.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
index 53ba8a56592e..6b87bd74b046 100644
--- a/drivers/usb/host/uhci-hcd.c
+++ b/drivers/usb/host/uhci-hcd.c
@@ -634,14 +634,14 @@ static int uhci_start(struct usb_hcd *hcd)
634 goto err_alloc_root_hub; 634 goto err_alloc_root_hub;
635 } 635 }
636 636
637 uhci->term_td = uhci_alloc_td(uhci, udev); 637 uhci->term_td = uhci_alloc_td(uhci);
638 if (!uhci->term_td) { 638 if (!uhci->term_td) {
639 dev_err(uhci_dev(uhci), "unable to allocate terminating TD\n"); 639 dev_err(uhci_dev(uhci), "unable to allocate terminating TD\n");
640 goto err_alloc_term_td; 640 goto err_alloc_term_td;
641 } 641 }
642 642
643 for (i = 0; i < UHCI_NUM_SKELQH; i++) { 643 for (i = 0; i < UHCI_NUM_SKELQH; i++) {
644 uhci->skelqh[i] = uhci_alloc_qh(uhci, udev); 644 uhci->skelqh[i] = uhci_alloc_qh(uhci);
645 if (!uhci->skelqh[i]) { 645 if (!uhci->skelqh[i]) {
646 dev_err(uhci_dev(uhci), "unable to allocate QH\n"); 646 dev_err(uhci_dev(uhci), "unable to allocate QH\n");
647 goto err_alloc_skelqh; 647 goto err_alloc_skelqh;