diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2006-10-17 16:57:18 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2006-10-17 16:57:18 -0400 |
commit | 64f89798da35f43c6ef6afda0541e25034513458 (patch) | |
tree | 419546d28bac423277b504b3a94ed7da333490ca /drivers/usb/host/ehci.h | |
parent | 4e4bc305e16440ab38060d61fbcb7d774881d2f1 (diff) |
USB: revert EHCI VIA workaround patch
This reverts 26f953fd884ea4879585287917f855c63c6b2666 which caused
resume problems on the mac mini.
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/host/ehci.h')
-rw-r--r-- | drivers/usb/host/ehci.h | 22 |
1 files changed, 7 insertions, 15 deletions
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h index 6aac39f50e07..bbc3082a73d7 100644 --- a/drivers/usb/host/ehci.h +++ b/drivers/usb/host/ehci.h | |||
@@ -58,6 +58,7 @@ struct ehci_hcd { /* one per controller */ | |||
58 | /* async schedule support */ | 58 | /* async schedule support */ |
59 | struct ehci_qh *async; | 59 | struct ehci_qh *async; |
60 | struct ehci_qh *reclaim; | 60 | struct ehci_qh *reclaim; |
61 | unsigned reclaim_ready : 1; | ||
61 | unsigned scanning : 1; | 62 | unsigned scanning : 1; |
62 | 63 | ||
63 | /* periodic schedule support */ | 64 | /* periodic schedule support */ |
@@ -80,7 +81,6 @@ struct ehci_hcd { /* one per controller */ | |||
80 | struct dma_pool *itd_pool; /* itd per iso urb */ | 81 | struct dma_pool *itd_pool; /* itd per iso urb */ |
81 | struct dma_pool *sitd_pool; /* sitd per split iso urb */ | 82 | struct dma_pool *sitd_pool; /* sitd per split iso urb */ |
82 | 83 | ||
83 | struct timer_list iaa_watchdog; | ||
84 | struct timer_list watchdog; | 84 | struct timer_list watchdog; |
85 | unsigned long actions; | 85 | unsigned long actions; |
86 | unsigned stamp; | 86 | unsigned stamp; |
@@ -114,21 +114,9 @@ static inline struct usb_hcd *ehci_to_hcd (struct ehci_hcd *ehci) | |||
114 | } | 114 | } |
115 | 115 | ||
116 | 116 | ||
117 | static inline void | ||
118 | iaa_watchdog_start (struct ehci_hcd *ehci) | ||
119 | { | ||
120 | WARN_ON(timer_pending(&ehci->iaa_watchdog)); | ||
121 | mod_timer (&ehci->iaa_watchdog, | ||
122 | jiffies + msecs_to_jiffies(EHCI_IAA_MSECS)); | ||
123 | } | ||
124 | |||
125 | static inline void iaa_watchdog_done (struct ehci_hcd *ehci) | ||
126 | { | ||
127 | del_timer (&ehci->iaa_watchdog); | ||
128 | } | ||
129 | |||
130 | enum ehci_timer_action { | 117 | enum ehci_timer_action { |
131 | TIMER_IO_WATCHDOG, | 118 | TIMER_IO_WATCHDOG, |
119 | TIMER_IAA_WATCHDOG, | ||
132 | TIMER_ASYNC_SHRINK, | 120 | TIMER_ASYNC_SHRINK, |
133 | TIMER_ASYNC_OFF, | 121 | TIMER_ASYNC_OFF, |
134 | }; | 122 | }; |
@@ -146,6 +134,9 @@ timer_action (struct ehci_hcd *ehci, enum ehci_timer_action action) | |||
146 | unsigned long t; | 134 | unsigned long t; |
147 | 135 | ||
148 | switch (action) { | 136 | switch (action) { |
137 | case TIMER_IAA_WATCHDOG: | ||
138 | t = EHCI_IAA_JIFFIES; | ||
139 | break; | ||
149 | case TIMER_IO_WATCHDOG: | 140 | case TIMER_IO_WATCHDOG: |
150 | t = EHCI_IO_JIFFIES; | 141 | t = EHCI_IO_JIFFIES; |
151 | break; | 142 | break; |
@@ -162,7 +153,8 @@ timer_action (struct ehci_hcd *ehci, enum ehci_timer_action action) | |||
162 | // async queue SHRINK often precedes IAA. while it's ready | 153 | // async queue SHRINK often precedes IAA. while it's ready |
163 | // to go OFF neither can matter, and afterwards the IO | 154 | // to go OFF neither can matter, and afterwards the IO |
164 | // watchdog stops unless there's still periodic traffic. | 155 | // watchdog stops unless there's still periodic traffic. |
165 | if (time_before_eq(t, ehci->watchdog.expires) | 156 | if (action != TIMER_IAA_WATCHDOG |
157 | && t > ehci->watchdog.expires | ||
166 | && timer_pending (&ehci->watchdog)) | 158 | && timer_pending (&ehci->watchdog)) |
167 | return; | 159 | return; |
168 | mod_timer (&ehci->watchdog, t); | 160 | mod_timer (&ehci->watchdog, t); |