USB: powerpc: Workaround for the PPC440EPX USBH_23 errata [take 3]

A published errata for ppc440epx states, that when running Linux with
both EHCI and OHCI modules loaded, the EHCI module experiences a fatal
error when a high-speed device is connected to the USB2.0, and
functions normally if OHCI module is not loaded.

There used to be recommendation to use only hi-speed or full-speed
devices with specific conditions, when respective module was unloaded.
Later, it was observed that ohci suspend is enough to keep things
going, and it was turned into workaround, as explained below.

Quote from original descriprion:

The 440EPx USB 2.0 Host controller is an EHCI compliant controller.  In
USB 2.0 Host controllers, each EHCI controller has one or more companion
controllers, which may be OHCI or UHCI.  An USB 2.0 Host controller will
contain one or more ports.  For each port, only one of the controllers
is connected at any one time. In the 440EPx, there is only one OHCI
companion controller, and only one USB 2.0 Host port.
All ports on an USB 2.0 controller default to the companion
controller.  If you load only an ohci driver, it will have control of
the ports and any deviceplugged in will operate, although high speed
devices will be forced to operate at full speed.  When an ehci driver
is loaded, it explicitly takes control of the ports.  If there is a
device connected, and / or every time there is a new device connected,
the ehci driver determines if the device is high speed or not.  If it
is high speed, the driver retains control of the port.  If it is not,
the driver explicitly gives the companion controller control of the
port.

The is a software workaround that uses
Initial version of the software workaround was posted to
linux-usb-devel:

http://www.mail-archive.com/linux-usb-devel@lists.sourceforge.net/msg54019.html

and later available from amcc.com:
http://www.amcc.com/Embedded/Downloads/download.html?cat=1&family=15&ins=2

The patch below is generally based on the latter, but reworked to
powerpc/of_device USB drivers, and uses a few devicetree inquiries to
get rid of (some) hardcoded defines.

Signed-off-by: Vitaly Bordug <vitb@kernel.crashing.org>
Signed-off-by: Stefan Roese <sr@denx.de>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 44 insertions, 1 deletions

diff --git a/drivers/usb/host/ehci-ppc-of.c b/drivers/usb/host/ehci-ppc-of.c
index b018deed2e8f..ef732b704f53 100644
--- a/drivers/usb/host/ehci-ppc-of.c
+++ b/drivers/usb/host/ehci-ppc-of.c
@@ -107,11 +107,13 @@ ehci_hcd_ppc_of_probe(struct of_device *op, const struct of_device_id *match)
 {
         struct device_node *dn = op->node;
         struct usb_hcd *hcd;
-        struct ehci_hcd *ehci;
+        struct ehci_hcd *ehci = NULL;
         struct resource res;
         int irq;
         int rv;
 
+        struct device_node *np;
+
         if (usb_disabled())
                 return -ENODEV;
 
@@ -149,6 +151,20 @@ ehci_hcd_ppc_of_probe(struct of_device *op, const struct of_device_id *match)
         }
 
         ehci = hcd_to_ehci(hcd);
+        np = of_find_compatible_node(NULL, NULL, "ibm,usb-ohci-440epx");
+        if (np != NULL) {
+                /* claim we really affected by usb23 erratum */
+                if (!of_address_to_resource(np, 0, &res))
+                        ehci->ohci_hcctrl_reg = ioremap(res.start +
+                                        OHCI_HCCTRL_OFFSET, OHCI_HCCTRL_LEN);
+                else
+                        pr_debug(__FILE__ ": no ohci offset in fdt\n");
+                if (!ehci->ohci_hcctrl_reg) {
+                        pr_debug(__FILE__ ": ioremap for ohci hcctrl failed\n");
+                } else {
+                        ehci->has_amcc_usb23 = 1;
+                }
+        }
 
         if (of_get_property(dn, "big-endian", NULL)) {
                 ehci->big_endian_mmio = 1;
@@ -181,6 +197,9 @@ err_ioremap:
         irq_dispose_mapping(irq);
 err_irq:
         release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
+
+        if (ehci->has_amcc_usb23)
+                iounmap(ehci->ohci_hcctrl_reg);
 err_rmr:
         usb_put_hcd(hcd);
 
@@ -191,6 +210,11 @@ err_rmr:
 static int ehci_hcd_ppc_of_remove(struct of_device *op)
 {
         struct usb_hcd *hcd = dev_get_drvdata(&op->dev);
+        struct ehci_hcd *ehci = hcd_to_ehci(hcd);
+
+        struct device_node *np;
+        struct resource res;
+
         dev_set_drvdata(&op->dev, NULL);
 
         dev_dbg(&op->dev, "stopping PPC-OF USB Controller\n");
@@ -201,6 +225,25 @@ static int ehci_hcd_ppc_of_remove(struct of_device *op)
         irq_dispose_mapping(hcd->irq);
         release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
 
+        /* use request_mem_region to test if the ohci driver is loaded.  if so
+         * ensure the ohci core is operational.
+         */
+        if (ehci->has_amcc_usb23) {
+                np = of_find_compatible_node(NULL, NULL, "ibm,usb-ohci-440epx");
+                if (np != NULL) {
+                        if (!of_address_to_resource(np, 0, &res))
+                                if (!request_mem_region(res.start,
+                                                            0x4, hcd_name))
+                                        set_ohci_hcfs(ehci, 1);
+                                else
+                                        release_mem_region(res.start, 0x4);
+                        else
+                                pr_debug(__FILE__ ": no ohci offset in fdt\n");
+                        of_node_put(np);
+                }
+
+                iounmap(ehci->ohci_hcctrl_reg);
+        }
         usb_put_hcd(hcd);
 
         return 0;