aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/host/ehci-pci.c
diff options
context:
space:
mode:
authorAlan Stern <stern@rowland.harvard.edu>2008-04-14 12:17:10 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2008-04-25 00:16:53 -0400
commit58a97ffeb2297f154659f339d77eb3f32c4d8b3e (patch)
tree2ca171b7f720769007f9c9624b74ca4ad3442f02 /drivers/usb/host/ehci-pci.c
parentb950bdbc67041412cb042e404938667204c7902c (diff)
USB: HCDs use the do_remote_wakeup flag
When a USB device is suspended, whether or not it is enabled for remote wakeup depends on the device_may_wakeup() setting. The setting is then saved in the do_remote_wakeup flag. Later on, however, the device_may_wakeup() value can change because of user activity. So when testing whether a suspended device is or should be enabled for remote wakeup, we should always test do_remote_wakeup instead of device_may_wakeup(). This patch (as1076) makes that change for root hubs in several places. The patch also adjusts uhci-hcd so that when an autostopped controller is suspended, the remote wakeup setting agrees with the value recorded in the root hub's do_remote_wakeup flag. And the patch adjusts ehci-hcd so that wakeup events on selectively suspended ports (i.e., the bus itself isn't suspended) don't turn on the PME# wakeup signal. Signed-off-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/host/ehci-pci.c')
-rw-r--r--drivers/usb/host/ehci-pci.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index a0afc78b273e..88dad4b53131 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
@@ -300,7 +300,7 @@ static int ehci_pci_resume(struct usb_hcd *hcd)
300 if (ehci_readl(ehci, &ehci->regs->configured_flag) == FLAG_CF) { 300 if (ehci_readl(ehci, &ehci->regs->configured_flag) == FLAG_CF) {
301 int mask = INTR_MASK; 301 int mask = INTR_MASK;
302 302
303 if (!device_may_wakeup(&hcd->self.root_hub->dev)) 303 if (!hcd->self.root_hub->do_remote_wakeup)
304 mask &= ~STS_PCD; 304 mask &= ~STS_PCD;
305 ehci_writel(ehci, mask, &ehci->regs->intr_enable); 305 ehci_writel(ehci, mask, &ehci->regs->intr_enable);
306 ehci_readl(ehci, &ehci->regs->intr_enable); 306 ehci_readl(ehci, &ehci->regs->intr_enable);