aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/gadget
diff options
context:
space:
mode:
authorRémi Denis-Courmont <remi.denis-courmont@nokia.com>2009-05-31 21:18:56 -0400
committerDavid S. Miller <davem@davemloft.net>2009-06-02 03:17:45 -0400
commitc69367fd6730a330c4ba54e9e699733439cbbabd (patch)
tree8e0f75b0223a4192f5fa6d4b399442638caaca1b /drivers/usb/gadget
parentfa202592796499dade5b3854643eaf0eed4d34ba (diff)
f_phonet: no need to check for carrier - scheduler does it internally
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/usb/gadget')
-rw-r--r--drivers/usb/gadget/f_phonet.c10
1 files changed, 2 insertions, 8 deletions
diff --git a/drivers/usb/gadget/f_phonet.c b/drivers/usb/gadget/f_phonet.c
index 54451ee02298..d6b48714d899 100644
--- a/drivers/usb/gadget/f_phonet.c
+++ b/drivers/usb/gadget/f_phonet.c
@@ -188,8 +188,7 @@ static struct usb_descriptor_header *hs_pn_function[] = {
188 188
189static int pn_net_open(struct net_device *dev) 189static int pn_net_open(struct net_device *dev)
190{ 190{
191 if (netif_carrier_ok(dev)) 191 netif_wake_queue(dev);
192 netif_wake_queue(dev);
193 return 0; 192 return 0;
194} 193}
195 194
@@ -219,8 +218,7 @@ static void pn_tx_complete(struct usb_ep *ep, struct usb_request *req)
219 } 218 }
220 219
221 dev_kfree_skb_any(skb); 220 dev_kfree_skb_any(skb);
222 if (netif_carrier_ok(dev)) 221 netif_wake_queue(dev);
223 netif_wake_queue(dev);
224} 222}
225 223
226static int pn_net_xmit(struct sk_buff *skb, struct net_device *dev) 224static int pn_net_xmit(struct sk_buff *skb, struct net_device *dev)
@@ -383,7 +381,6 @@ static void __pn_reset(struct usb_function *f)
383 struct phonet_port *port = netdev_priv(dev); 381 struct phonet_port *port = netdev_priv(dev);
384 382
385 netif_carrier_off(dev); 383 netif_carrier_off(dev);
386 netif_stop_queue(dev);
387 port->usb = NULL; 384 port->usb = NULL;
388 385
389 usb_ep_disable(fp->out_ep); 386 usb_ep_disable(fp->out_ep);
@@ -427,8 +424,6 @@ static int pn_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
427 fp->in_ep->driver_data = fp; 424 fp->in_ep->driver_data = fp;
428 425
429 netif_carrier_on(dev); 426 netif_carrier_on(dev);
430 if (netif_running(dev))
431 netif_wake_queue(dev);
432 for (i = 0; i < phonet_rxq_size; i++) 427 for (i = 0; i < phonet_rxq_size; i++)
433 pn_rx_submit(fp, fp->out_reqv[i], GFP_ATOMIC); 428 pn_rx_submit(fp, fp->out_reqv[i], GFP_ATOMIC);
434 } 429 }
@@ -610,7 +605,6 @@ int __init gphonet_setup(struct usb_gadget *gadget)
610 port = netdev_priv(dev); 605 port = netdev_priv(dev);
611 spin_lock_init(&port->lock); 606 spin_lock_init(&port->lock);
612 netif_carrier_off(dev); 607 netif_carrier_off(dev);
613 netif_stop_queue(dev);
614 SET_NETDEV_DEV(dev, &gadget->dev); 608 SET_NETDEV_DEV(dev, &gadget->dev);
615 609
616 err = register_netdev(dev); 610 err = register_netdev(dev);