aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/gadget
diff options
context:
space:
mode:
authorYauhen Kharuzhy <jekhor@gmail.com>2008-09-12 12:02:23 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2008-10-17 17:40:58 -0400
commitf9e9cff613b8239ce9159735aa662c9c85b478bf (patch)
tree2d9c90e6904d6dcdb4d54b0efc36a315e8777ce1 /drivers/usb/gadget
parent36e893d25aa2abcae0f11ef263de0e8322641386 (diff)
USB: Fix s3c2410_udc usb speed handling
The new composite framework revealed a weakness in the s3c2410_udc driver gadget register function. Instead of checking if speed asked for was USB_LOW_SPEED upon usb_gadget_register() to deny service, it checked only for USB_FULL_SPEED, thus denying service to usb high speed capable gadgets (like g_ether). Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com> Cc: stable <stable@kernel.org> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/gadget')
-rw-r--r--drivers/usb/gadget/s3c2410_udc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
index 29d13ebe7500..48f51b12d2e2 100644
--- a/drivers/usb/gadget/s3c2410_udc.c
+++ b/drivers/usb/gadget/s3c2410_udc.c
@@ -1651,7 +1651,7 @@ int usb_gadget_register_driver(struct usb_gadget_driver *driver)
1651 return -EBUSY; 1651 return -EBUSY;
1652 1652
1653 if (!driver->bind || !driver->setup 1653 if (!driver->bind || !driver->setup
1654 || driver->speed != USB_SPEED_FULL) { 1654 || driver->speed < USB_SPEED_FULL) {
1655 printk(KERN_ERR "Invalid driver: bind %p setup %p speed %d\n", 1655 printk(KERN_ERR "Invalid driver: bind %p setup %p speed %d\n",
1656 driver->bind, driver->setup, driver->speed); 1656 driver->bind, driver->setup, driver->speed);
1657 return -EINVAL; 1657 return -EINVAL;