diff options
author | Denis V. Lunev <den@openvz.org> | 2008-04-29 04:02:19 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-29 11:06:21 -0400 |
commit | cdefa185dda6b2b267f088a7477e96d845bdc6c1 (patch) | |
tree | 95447a4c46352d6a353074873c11446e7c3c657f /drivers/usb/gadget/omap_udc.c | |
parent | a973909fc32be90884280b7a8cd2f2e093c97890 (diff) |
usb: use non-racy method for proc entries creation
Use proc_create()/proc_create_data() to make sure that ->proc_fops and ->data
be setup before gluing PDE to main tree.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/usb/gadget/omap_udc.c')
-rw-r--r-- | drivers/usb/gadget/omap_udc.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c index 95f7662376f1..881d74c3d964 100644 --- a/drivers/usb/gadget/omap_udc.c +++ b/drivers/usb/gadget/omap_udc.c | |||
@@ -2504,6 +2504,7 @@ static int proc_udc_open(struct inode *inode, struct file *file) | |||
2504 | } | 2504 | } |
2505 | 2505 | ||
2506 | static const struct file_operations proc_ops = { | 2506 | static const struct file_operations proc_ops = { |
2507 | .owner = THIS_MODULE, | ||
2507 | .open = proc_udc_open, | 2508 | .open = proc_udc_open, |
2508 | .read = seq_read, | 2509 | .read = seq_read, |
2509 | .llseek = seq_lseek, | 2510 | .llseek = seq_lseek, |
@@ -2512,11 +2513,7 @@ static const struct file_operations proc_ops = { | |||
2512 | 2513 | ||
2513 | static void create_proc_file(void) | 2514 | static void create_proc_file(void) |
2514 | { | 2515 | { |
2515 | struct proc_dir_entry *pde; | 2516 | proc_create(proc_filename, 0, NULL, &proc_ops); |
2516 | |||
2517 | pde = create_proc_entry (proc_filename, 0, NULL); | ||
2518 | if (pde) | ||
2519 | pde->proc_fops = &proc_ops; | ||
2520 | } | 2517 | } |
2521 | 2518 | ||
2522 | static void remove_proc_file(void) | 2519 | static void remove_proc_file(void) |