diff options
author | Eric Sesterhenn <snakebyte@gmx.de> | 2006-02-27 16:34:10 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2006-03-20 17:49:59 -0500 |
commit | 7039f4224d4e40b06308d5c1a97427af1a142459 (patch) | |
tree | 4529171195b1008e8615bb4b39a129ddda463b16 /drivers/usb/gadget/omap_udc.c | |
parent | 80b6ca48321974a6566a1c9048ba34f60420bca6 (diff) |
[PATCH] USB: kzalloc() conversion in drivers/usb/gadget
this patch converts drivers/usb to kzalloc usage.
Compile tested with allyes config.
I think there was a bug in drivers/usb/gadget/inode.c because
it used sizeof(*data) for the kmalloc() and sizeof(data) for
the memset(), since sizeof(data) just returns the size for a pointer.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/gadget/omap_udc.c')
-rw-r--r-- | drivers/usb/gadget/omap_udc.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c index a8972d7c97be..fbea51448909 100644 --- a/drivers/usb/gadget/omap_udc.c +++ b/drivers/usb/gadget/omap_udc.c | |||
@@ -273,9 +273,8 @@ omap_alloc_request(struct usb_ep *ep, gfp_t gfp_flags) | |||
273 | { | 273 | { |
274 | struct omap_req *req; | 274 | struct omap_req *req; |
275 | 275 | ||
276 | req = kmalloc(sizeof *req, gfp_flags); | 276 | req = kzalloc(sizeof(*req), gfp_flags); |
277 | if (req) { | 277 | if (req) { |
278 | memset (req, 0, sizeof *req); | ||
279 | req->req.dma = DMA_ADDR_INVALID; | 278 | req->req.dma = DMA_ADDR_INVALID; |
280 | INIT_LIST_HEAD (&req->queue); | 279 | INIT_LIST_HEAD (&req->queue); |
281 | } | 280 | } |
@@ -2586,11 +2585,10 @@ omap_udc_setup(struct platform_device *odev, struct otg_transceiver *xceiv) | |||
2586 | /* UDC_PULLUP_EN gates the chip clock */ | 2585 | /* UDC_PULLUP_EN gates the chip clock */ |
2587 | // OTG_SYSCON_1_REG |= DEV_IDLE_EN; | 2586 | // OTG_SYSCON_1_REG |= DEV_IDLE_EN; |
2588 | 2587 | ||
2589 | udc = kmalloc (sizeof *udc, SLAB_KERNEL); | 2588 | udc = kzalloc(sizeof(*udc), SLAB_KERNEL); |
2590 | if (!udc) | 2589 | if (!udc) |
2591 | return -ENOMEM; | 2590 | return -ENOMEM; |
2592 | 2591 | ||
2593 | memset(udc, 0, sizeof *udc); | ||
2594 | spin_lock_init (&udc->lock); | 2592 | spin_lock_init (&udc->lock); |
2595 | 2593 | ||
2596 | udc->gadget.ops = &omap_gadget_ops; | 2594 | udc->gadget.ops = &omap_gadget_ops; |