usb gadget stack: remove usb_ep_*_buffer(), part 2

This patch removes controller driver infrastructure which supported
the now-removed usb_ep_{alloc,free}_buffer() calls.

As can be seen, many of the implementations of this were broken to
various degrees.  Many didn't properly return dma-coherent mappings;
those which did so were necessarily ugly because of bogosity in the
underlying dma_free_coherent() calls ... which on many platforms
can't be called from the same contexts (notably in_irq) from which
their dma_alloc_coherent() sibling can be called.

The main potential downside of removing this is that gadget drivers
wouldn't have specific knowledge that the controller drivers have:
endpoints that aren't dma-capable don't need any dma mappings at all.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 0 insertions, 36 deletions

diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index 9040b50d6425..f2fbdc7fe376 100644
--- a/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -497,38 +497,6 @@ dummy_free_request (struct usb_ep *_ep, struct usb_request *_req)
         kfree (req);
 }
 
-static void *
-dummy_alloc_buffer (
-        struct usb_ep *_ep,
-        unsigned bytes,
-        dma_addr_t *dma,
-        gfp_t mem_flags
-) {
-        char                    *retval;
-        struct dummy_ep         *ep;
-        struct dummy            *dum;
-
-        ep = usb_ep_to_dummy_ep (_ep);
-        dum = ep_to_dummy (ep);
-
-        if (!dum->driver)
-                return NULL;
-        retval = kmalloc (bytes, mem_flags);
-        *dma = (dma_addr_t) retval;
-        return retval;
-}
-
-static void
-dummy_free_buffer (
-        struct usb_ep *_ep,
-        void *buf,
-        dma_addr_t dma,
-        unsigned bytes
-) {
-        if (bytes)
-                kfree (buf);
-}
-
 static void
 fifo_complete (struct usb_ep *ep, struct usb_request *req)
 {
@@ -659,10 +627,6 @@ static const struct usb_ep_ops dummy_ep_ops = {
         .alloc_request  = dummy_alloc_request,
         .free_request   = dummy_free_request,
 
-        .alloc_buffer   = dummy_alloc_buffer,
-        .free_buffer    = dummy_free_buffer,
-        /* map, unmap, ... eventually hook the "generic" dma calls */
-
         .queue          = dummy_queue,
         .dequeue        = dummy_dequeue,