diff options
author | Stephen Hemminger <shemminger@osdl.org> | 2006-11-14 13:06:17 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2006-12-01 17:23:30 -0500 |
commit | d5ec1686ba96eb75e132196c486cc0521b00f12c (patch) | |
tree | 8bfeffb5389d008750b20a893ad1e653867bcdcb /drivers/usb/core | |
parent | d8126a0c23b95d8f49a8f4b49191691f9a09ae4a (diff) |
USB: resume_device symbol conflict
Several functions in USB core overlap with global functions.
The linker appears to do the right thing, but it is bad practice and makes
debugging harder.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/core')
-rw-r--r-- | drivers/usb/core/driver.c | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index 204495fa6b3d..44dd6103fb44 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c | |||
@@ -810,7 +810,7 @@ EXPORT_SYMBOL_GPL_FUTURE(usb_deregister); | |||
810 | #ifdef CONFIG_PM | 810 | #ifdef CONFIG_PM |
811 | 811 | ||
812 | /* Caller has locked udev's pm_mutex */ | 812 | /* Caller has locked udev's pm_mutex */ |
813 | static int suspend_device(struct usb_device *udev, pm_message_t msg) | 813 | static int usb_suspend_device(struct usb_device *udev, pm_message_t msg) |
814 | { | 814 | { |
815 | struct usb_device_driver *udriver; | 815 | struct usb_device_driver *udriver; |
816 | int status = 0; | 816 | int status = 0; |
@@ -837,7 +837,7 @@ done: | |||
837 | } | 837 | } |
838 | 838 | ||
839 | /* Caller has locked udev's pm_mutex */ | 839 | /* Caller has locked udev's pm_mutex */ |
840 | static int resume_device(struct usb_device *udev) | 840 | static int usb_resume_device(struct usb_device *udev) |
841 | { | 841 | { |
842 | struct usb_device_driver *udriver; | 842 | struct usb_device_driver *udriver; |
843 | int status = 0; | 843 | int status = 0; |
@@ -863,7 +863,7 @@ done: | |||
863 | } | 863 | } |
864 | 864 | ||
865 | /* Caller has locked intf's usb_device's pm mutex */ | 865 | /* Caller has locked intf's usb_device's pm mutex */ |
866 | static int suspend_interface(struct usb_interface *intf, pm_message_t msg) | 866 | static int usb_suspend_interface(struct usb_interface *intf, pm_message_t msg) |
867 | { | 867 | { |
868 | struct usb_driver *driver; | 868 | struct usb_driver *driver; |
869 | int status = 0; | 869 | int status = 0; |
@@ -900,7 +900,7 @@ done: | |||
900 | } | 900 | } |
901 | 901 | ||
902 | /* Caller has locked intf's usb_device's pm_mutex */ | 902 | /* Caller has locked intf's usb_device's pm_mutex */ |
903 | static int resume_interface(struct usb_interface *intf) | 903 | static int usb_resume_interface(struct usb_interface *intf) |
904 | { | 904 | { |
905 | struct usb_driver *driver; | 905 | struct usb_driver *driver; |
906 | int status = 0; | 906 | int status = 0; |
@@ -1031,19 +1031,19 @@ int usb_suspend_both(struct usb_device *udev, pm_message_t msg) | |||
1031 | if (udev->actconfig) { | 1031 | if (udev->actconfig) { |
1032 | for (; i < udev->actconfig->desc.bNumInterfaces; i++) { | 1032 | for (; i < udev->actconfig->desc.bNumInterfaces; i++) { |
1033 | intf = udev->actconfig->interface[i]; | 1033 | intf = udev->actconfig->interface[i]; |
1034 | status = suspend_interface(intf, msg); | 1034 | status = usb_suspend_interface(intf, msg); |
1035 | if (status != 0) | 1035 | if (status != 0) |
1036 | break; | 1036 | break; |
1037 | } | 1037 | } |
1038 | } | 1038 | } |
1039 | if (status == 0) | 1039 | if (status == 0) |
1040 | status = suspend_device(udev, msg); | 1040 | status = usb_suspend_device(udev, msg); |
1041 | 1041 | ||
1042 | /* If the suspend failed, resume interfaces that did get suspended */ | 1042 | /* If the suspend failed, resume interfaces that did get suspended */ |
1043 | if (status != 0) { | 1043 | if (status != 0) { |
1044 | while (--i >= 0) { | 1044 | while (--i >= 0) { |
1045 | intf = udev->actconfig->interface[i]; | 1045 | intf = udev->actconfig->interface[i]; |
1046 | resume_interface(intf); | 1046 | usb_resume_interface(intf); |
1047 | } | 1047 | } |
1048 | 1048 | ||
1049 | /* If the suspend succeeded, propagate it up the tree */ | 1049 | /* If the suspend succeeded, propagate it up the tree */ |
@@ -1109,14 +1109,14 @@ int usb_resume_both(struct usb_device *udev) | |||
1109 | status = -EHOSTUNREACH; | 1109 | status = -EHOSTUNREACH; |
1110 | } | 1110 | } |
1111 | if (status == 0) | 1111 | if (status == 0) |
1112 | status = resume_device(udev); | 1112 | status = usb_resume_device(udev); |
1113 | if (parent) | 1113 | if (parent) |
1114 | usb_pm_unlock(parent); | 1114 | usb_pm_unlock(parent); |
1115 | } else { | 1115 | } else { |
1116 | 1116 | ||
1117 | /* Needed only for setting udev->dev.power.power_state.event | 1117 | /* Needed only for setting udev->dev.power.power_state.event |
1118 | * and for possible debugging message. */ | 1118 | * and for possible debugging message. */ |
1119 | status = resume_device(udev); | 1119 | status = usb_resume_device(udev); |
1120 | } | 1120 | } |
1121 | 1121 | ||
1122 | /* Now the parent won't suspend until we are finished */ | 1122 | /* Now the parent won't suspend until we are finished */ |
@@ -1124,7 +1124,7 @@ int usb_resume_both(struct usb_device *udev) | |||
1124 | if (status == 0 && udev->actconfig) { | 1124 | if (status == 0 && udev->actconfig) { |
1125 | for (i = 0; i < udev->actconfig->desc.bNumInterfaces; i++) { | 1125 | for (i = 0; i < udev->actconfig->desc.bNumInterfaces; i++) { |
1126 | intf = udev->actconfig->interface[i]; | 1126 | intf = udev->actconfig->interface[i]; |
1127 | resume_interface(intf); | 1127 | usb_resume_interface(intf); |
1128 | } | 1128 | } |
1129 | } | 1129 | } |
1130 | 1130 | ||