diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2009-06-15 16:13:05 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-06-16 00:44:48 -0400 |
commit | a92b63e7e4c185b4dd9e87762e2cb716e54482d0 (patch) | |
tree | af8b5556def527aa7c362ec4c455f09178fdff27 /drivers/usb/class/usbtmc.c | |
parent | 3b6c023f831e3179c42bbcff189c73628cd5ea4c (diff) |
USB: usbtmc: fix switch statment
Steve Holland pointed out that we forgot to call break; in the switch
statment. This probably resolves a lot of the bug reports I've gotten
for the driver lately.
Stupid me...
Reported-by: Steve Holland <sdh4@iastate.edu>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/class/usbtmc.c')
-rw-r--r-- | drivers/usb/class/usbtmc.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index c40a9b284cc9..3703789d0d2a 100644 --- a/drivers/usb/class/usbtmc.c +++ b/drivers/usb/class/usbtmc.c | |||
@@ -927,21 +927,27 @@ static long usbtmc_ioctl(struct file *file, unsigned int cmd, unsigned long arg) | |||
927 | switch (cmd) { | 927 | switch (cmd) { |
928 | case USBTMC_IOCTL_CLEAR_OUT_HALT: | 928 | case USBTMC_IOCTL_CLEAR_OUT_HALT: |
929 | retval = usbtmc_ioctl_clear_out_halt(data); | 929 | retval = usbtmc_ioctl_clear_out_halt(data); |
930 | break; | ||
930 | 931 | ||
931 | case USBTMC_IOCTL_CLEAR_IN_HALT: | 932 | case USBTMC_IOCTL_CLEAR_IN_HALT: |
932 | retval = usbtmc_ioctl_clear_in_halt(data); | 933 | retval = usbtmc_ioctl_clear_in_halt(data); |
934 | break; | ||
933 | 935 | ||
934 | case USBTMC_IOCTL_INDICATOR_PULSE: | 936 | case USBTMC_IOCTL_INDICATOR_PULSE: |
935 | retval = usbtmc_ioctl_indicator_pulse(data); | 937 | retval = usbtmc_ioctl_indicator_pulse(data); |
938 | break; | ||
936 | 939 | ||
937 | case USBTMC_IOCTL_CLEAR: | 940 | case USBTMC_IOCTL_CLEAR: |
938 | retval = usbtmc_ioctl_clear(data); | 941 | retval = usbtmc_ioctl_clear(data); |
942 | break; | ||
939 | 943 | ||
940 | case USBTMC_IOCTL_ABORT_BULK_OUT: | 944 | case USBTMC_IOCTL_ABORT_BULK_OUT: |
941 | retval = usbtmc_ioctl_abort_bulk_out(data); | 945 | retval = usbtmc_ioctl_abort_bulk_out(data); |
946 | break; | ||
942 | 947 | ||
943 | case USBTMC_IOCTL_ABORT_BULK_IN: | 948 | case USBTMC_IOCTL_ABORT_BULK_IN: |
944 | retval = usbtmc_ioctl_abort_bulk_in(data); | 949 | retval = usbtmc_ioctl_abort_bulk_in(data); |
950 | break; | ||
945 | } | 951 | } |
946 | 952 | ||
947 | mutex_unlock(&data->io_mutex); | 953 | mutex_unlock(&data->io_mutex); |