diff options
author | Barry Song <21cnbao@gmail.com> | 2013-08-14 18:52:14 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-08-14 21:33:08 -0400 |
commit | a343756e07884e4cecd3a4297de7f121e5bb8829 (patch) | |
tree | d33e91b4bdc8e361be3489cd310d68e4ecd1ae1e /drivers/tty | |
parent | 4a0ac0f55b18dc297a87a85417fcf068658bf103 (diff) |
serial: sirf: drop redundant pinctrl_get_select_default as pinctrl core does it
pinctrl core will get default pinmux, so drop it in the sirfsoc serial driver.
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
-rw-r--r-- | drivers/tty/serial/sirfsoc_uart.c | 16 | ||||
-rw-r--r-- | drivers/tty/serial/sirfsoc_uart.h | 1 |
2 files changed, 1 insertions, 16 deletions
diff --git a/drivers/tty/serial/sirfsoc_uart.c b/drivers/tty/serial/sirfsoc_uart.c index d28f38b83332..d87003d49c05 100644 --- a/drivers/tty/serial/sirfsoc_uart.c +++ b/drivers/tty/serial/sirfsoc_uart.c | |||
@@ -22,7 +22,6 @@ | |||
22 | #include <linux/io.h> | 22 | #include <linux/io.h> |
23 | #include <asm/irq.h> | 23 | #include <asm/irq.h> |
24 | #include <asm/mach/irq.h> | 24 | #include <asm/mach/irq.h> |
25 | #include <linux/pinctrl/consumer.h> | ||
26 | 25 | ||
27 | #include "sirfsoc_uart.h" | 26 | #include "sirfsoc_uart.h" |
28 | 27 | ||
@@ -893,17 +892,10 @@ static int sirfsoc_uart_probe(struct platform_device *pdev) | |||
893 | } | 892 | } |
894 | port->irq = res->start; | 893 | port->irq = res->start; |
895 | 894 | ||
896 | if (sirfport->hw_flow_ctrl) { | ||
897 | sirfport->p = pinctrl_get_select_default(&pdev->dev); | ||
898 | ret = IS_ERR(sirfport->p); | ||
899 | if (ret) | ||
900 | goto err; | ||
901 | } | ||
902 | |||
903 | sirfport->clk = clk_get(&pdev->dev, NULL); | 895 | sirfport->clk = clk_get(&pdev->dev, NULL); |
904 | if (IS_ERR(sirfport->clk)) { | 896 | if (IS_ERR(sirfport->clk)) { |
905 | ret = PTR_ERR(sirfport->clk); | 897 | ret = PTR_ERR(sirfport->clk); |
906 | goto clk_err; | 898 | goto err; |
907 | } | 899 | } |
908 | clk_prepare_enable(sirfport->clk); | 900 | clk_prepare_enable(sirfport->clk); |
909 | port->uartclk = clk_get_rate(sirfport->clk); | 901 | port->uartclk = clk_get_rate(sirfport->clk); |
@@ -923,9 +915,6 @@ static int sirfsoc_uart_probe(struct platform_device *pdev) | |||
923 | port_err: | 915 | port_err: |
924 | clk_disable_unprepare(sirfport->clk); | 916 | clk_disable_unprepare(sirfport->clk); |
925 | clk_put(sirfport->clk); | 917 | clk_put(sirfport->clk); |
926 | clk_err: | ||
927 | if (sirfport->hw_flow_ctrl) | ||
928 | pinctrl_put(sirfport->p); | ||
929 | err: | 918 | err: |
930 | return ret; | 919 | return ret; |
931 | } | 920 | } |
@@ -934,9 +923,6 @@ static int sirfsoc_uart_remove(struct platform_device *pdev) | |||
934 | { | 923 | { |
935 | struct sirfsoc_uart_port *sirfport = platform_get_drvdata(pdev); | 924 | struct sirfsoc_uart_port *sirfport = platform_get_drvdata(pdev); |
936 | struct uart_port *port = &sirfport->port; | 925 | struct uart_port *port = &sirfport->port; |
937 | |||
938 | if (sirfport->hw_flow_ctrl) | ||
939 | pinctrl_put(sirfport->p); | ||
940 | clk_disable_unprepare(sirfport->clk); | 926 | clk_disable_unprepare(sirfport->clk); |
941 | clk_put(sirfport->clk); | 927 | clk_put(sirfport->clk); |
942 | uart_remove_one_port(&sirfsoc_uart_drv, port); | 928 | uart_remove_one_port(&sirfsoc_uart_drv, port); |
diff --git a/drivers/tty/serial/sirfsoc_uart.h b/drivers/tty/serial/sirfsoc_uart.h index 6f6d27547844..2b41b06362df 100644 --- a/drivers/tty/serial/sirfsoc_uart.h +++ b/drivers/tty/serial/sirfsoc_uart.h | |||
@@ -367,7 +367,6 @@ struct sirfsoc_uart_port { | |||
367 | unsigned char ms_enabled; | 367 | unsigned char ms_enabled; |
368 | 368 | ||
369 | struct uart_port port; | 369 | struct uart_port port; |
370 | struct pinctrl *p; | ||
371 | struct clk *clk; | 370 | struct clk *clk; |
372 | /* for SiRFmarco, there are SET/CLR for UART_INT_EN */ | 371 | /* for SiRFmarco, there are SET/CLR for UART_INT_EN */ |
373 | bool is_marco; | 372 | bool is_marco; |