diff options
author | Peter Hurley <peter@hurleysoftware.com> | 2014-10-16 15:33:22 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-11-05 19:34:36 -0500 |
commit | 6460fbbf476ad8d4f4196534c00019975b33e1db (patch) | |
tree | e3bc22df1f753a369bb23ecd4a308e605ee92d30 /drivers/tty/pty.c | |
parent | a361858da327263e04dc521ca39091d3119ccff8 (diff) |
tty: WARN for attempted set_termios() of pty master
The pty master's termios should never be set; currently, all code
paths which call the driver's set_termios() method ensure that the
pty slave's termios is being set.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Reviewed-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/pty.c')
-rw-r--r-- | drivers/tty/pty.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c index 4c0218db85ad..6c7602592fe0 100644 --- a/drivers/tty/pty.c +++ b/drivers/tty/pty.c | |||
@@ -477,7 +477,6 @@ static const struct tty_operations master_pty_ops_bsd = { | |||
477 | .flush_buffer = pty_flush_buffer, | 477 | .flush_buffer = pty_flush_buffer, |
478 | .chars_in_buffer = pty_chars_in_buffer, | 478 | .chars_in_buffer = pty_chars_in_buffer, |
479 | .unthrottle = pty_unthrottle, | 479 | .unthrottle = pty_unthrottle, |
480 | .set_termios = pty_set_termios, | ||
481 | .ioctl = pty_bsd_ioctl, | 480 | .ioctl = pty_bsd_ioctl, |
482 | .cleanup = pty_cleanup, | 481 | .cleanup = pty_cleanup, |
483 | .resize = pty_resize, | 482 | .resize = pty_resize, |
@@ -654,7 +653,6 @@ static const struct tty_operations ptm_unix98_ops = { | |||
654 | .flush_buffer = pty_flush_buffer, | 653 | .flush_buffer = pty_flush_buffer, |
655 | .chars_in_buffer = pty_chars_in_buffer, | 654 | .chars_in_buffer = pty_chars_in_buffer, |
656 | .unthrottle = pty_unthrottle, | 655 | .unthrottle = pty_unthrottle, |
657 | .set_termios = pty_set_termios, | ||
658 | .ioctl = pty_unix98_ioctl, | 656 | .ioctl = pty_unix98_ioctl, |
659 | .resize = pty_resize, | 657 | .resize = pty_resize, |
660 | .shutdown = pty_unix98_shutdown, | 658 | .shutdown = pty_unix98_shutdown, |