diff options
author | Russ Gorby <russ.gorby@intel.com> | 2012-08-13 08:45:15 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-08-16 15:03:30 -0400 |
commit | 329e56780e514a7ab607bcb51a52ab0dc2669414 (patch) | |
tree | fbc5250c682ee48491ca170e8621d1733f77c060 /drivers/tty/n_gsm.c | |
parent | b4338e1efc339986cf6c0a3652906e914a86e2d3 (diff) |
n_gsm: replace kfree_skb w/ appropriate dev_* versions
Drivers are supposed to use the dev_* versions of the kfree_skb
interfaces. In a couple of cases we were called with IRQs
disabled as well which kfree_skb() does not expect.
Replaced kfree_skb calls w/ dev_kfree_skb and dev_kfree_skb_any
Signed-off-by: Russ Gorby <russ.gorby@intel.com>
Tested-by: Yin, Fengwei <fengwei.yin@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Cc: Grooming <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/n_gsm.c')
-rw-r--r-- | drivers/tty/n_gsm.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 6f4f8d3654d2..a8c82f5d769b 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c | |||
@@ -879,7 +879,7 @@ static int gsm_dlci_data_output_framed(struct gsm_mux *gsm, | |||
879 | if (len > gsm->mtu) { | 879 | if (len > gsm->mtu) { |
880 | if (dlci->adaption == 3) { | 880 | if (dlci->adaption == 3) { |
881 | /* Over long frame, bin it */ | 881 | /* Over long frame, bin it */ |
882 | kfree_skb(dlci->skb); | 882 | dev_kfree_skb_any(dlci->skb); |
883 | dlci->skb = NULL; | 883 | dlci->skb = NULL; |
884 | return 0; | 884 | return 0; |
885 | } | 885 | } |
@@ -905,7 +905,7 @@ static int gsm_dlci_data_output_framed(struct gsm_mux *gsm, | |||
905 | skb_pull(dlci->skb, len); | 905 | skb_pull(dlci->skb, len); |
906 | __gsm_data_queue(dlci, msg); | 906 | __gsm_data_queue(dlci, msg); |
907 | if (last) { | 907 | if (last) { |
908 | kfree_skb(dlci->skb); | 908 | dev_kfree_skb_any(dlci->skb); |
909 | dlci->skb = NULL; | 909 | dlci->skb = NULL; |
910 | } | 910 | } |
911 | return size; | 911 | return size; |
@@ -1674,7 +1674,7 @@ static void gsm_dlci_free(struct kref *ref) | |||
1674 | dlci->gsm->dlci[dlci->addr] = NULL; | 1674 | dlci->gsm->dlci[dlci->addr] = NULL; |
1675 | kfifo_free(dlci->fifo); | 1675 | kfifo_free(dlci->fifo); |
1676 | while ((dlci->skb = skb_dequeue(&dlci->skb_list))) | 1676 | while ((dlci->skb = skb_dequeue(&dlci->skb_list))) |
1677 | kfree_skb(dlci->skb); | 1677 | dev_kfree_skb(dlci->skb); |
1678 | kfree(dlci); | 1678 | kfree(dlci); |
1679 | } | 1679 | } |
1680 | 1680 | ||
@@ -2013,7 +2013,7 @@ void gsm_cleanup_mux(struct gsm_mux *gsm) | |||
2013 | { | 2013 | { |
2014 | int i; | 2014 | int i; |
2015 | struct gsm_dlci *dlci = gsm->dlci[0]; | 2015 | struct gsm_dlci *dlci = gsm->dlci[0]; |
2016 | struct gsm_msg *txq, *utxq; | 2016 | struct gsm_msg *txq, *ntxq; |
2017 | struct gsm_control *gc; | 2017 | struct gsm_control *gc; |
2018 | 2018 | ||
2019 | gsm->dead = 1; | 2019 | gsm->dead = 1; |