diff options
author | Alan Cox <alan@linux.intel.com> | 2012-01-26 12:44:09 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2012-01-26 20:14:50 -0500 |
commit | d4e33fac2408d37f7b52e80ca2a89f9fb482914f (patch) | |
tree | dd25baa1bc251ad2aa61a07eda7f95a4d7094126 /drivers/tty/hvc | |
parent | 3afbd89c9639c344300dcdd7d4e5e18dda559fd4 (diff) |
serial: Kill off NO_IRQ
We transform the offenders into a test of irq <= 0 which will be ok while
the ARM people get their platform sorted. Once that is done (or in a while
if they don't do it anyway) then we will change them all to !irq checks.
For arch specific drivers that are already using NO_IRQ = 0 we just test
against zero so we don't need to re-review them later.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/tty/hvc')
-rw-r--r-- | drivers/tty/hvc/hvc_beat.c | 2 | ||||
-rw-r--r-- | drivers/tty/hvc/hvc_rtas.c | 2 | ||||
-rw-r--r-- | drivers/tty/hvc/hvc_udbg.c | 2 | ||||
-rw-r--r-- | drivers/tty/hvc/hvc_xen.c | 2 | ||||
-rw-r--r-- | drivers/tty/hvc/hvcs.c | 4 | ||||
-rw-r--r-- | drivers/tty/hvc/hvsi.c | 2 |
6 files changed, 7 insertions, 7 deletions
diff --git a/drivers/tty/hvc/hvc_beat.c b/drivers/tty/hvc/hvc_beat.c index 5fe4631e2a61..1560d235449e 100644 --- a/drivers/tty/hvc/hvc_beat.c +++ b/drivers/tty/hvc/hvc_beat.c | |||
@@ -113,7 +113,7 @@ static int __init hvc_beat_init(void) | |||
113 | if (!firmware_has_feature(FW_FEATURE_BEAT)) | 113 | if (!firmware_has_feature(FW_FEATURE_BEAT)) |
114 | return -ENODEV; | 114 | return -ENODEV; |
115 | 115 | ||
116 | hp = hvc_alloc(0, NO_IRQ, &hvc_beat_get_put_ops, 16); | 116 | hp = hvc_alloc(0, 0, &hvc_beat_get_put_ops, 16); |
117 | if (IS_ERR(hp)) | 117 | if (IS_ERR(hp)) |
118 | return PTR_ERR(hp); | 118 | return PTR_ERR(hp); |
119 | hvc_beat_dev = hp; | 119 | hvc_beat_dev = hp; |
diff --git a/drivers/tty/hvc/hvc_rtas.c b/drivers/tty/hvc/hvc_rtas.c index 61c4a61558d9..0069bb86ba49 100644 --- a/drivers/tty/hvc/hvc_rtas.c +++ b/drivers/tty/hvc/hvc_rtas.c | |||
@@ -94,7 +94,7 @@ static int __init hvc_rtas_init(void) | |||
94 | 94 | ||
95 | /* Allocate an hvc_struct for the console device we instantiated | 95 | /* Allocate an hvc_struct for the console device we instantiated |
96 | * earlier. Save off hp so that we can return it on exit */ | 96 | * earlier. Save off hp so that we can return it on exit */ |
97 | hp = hvc_alloc(hvc_rtas_cookie, NO_IRQ, &hvc_rtas_get_put_ops, 16); | 97 | hp = hvc_alloc(hvc_rtas_cookie, 0, &hvc_rtas_get_put_ops, 16); |
98 | if (IS_ERR(hp)) | 98 | if (IS_ERR(hp)) |
99 | return PTR_ERR(hp); | 99 | return PTR_ERR(hp); |
100 | 100 | ||
diff --git a/drivers/tty/hvc/hvc_udbg.c b/drivers/tty/hvc/hvc_udbg.c index b0957e61a7be..4c9b13e7748c 100644 --- a/drivers/tty/hvc/hvc_udbg.c +++ b/drivers/tty/hvc/hvc_udbg.c | |||
@@ -69,7 +69,7 @@ static int __init hvc_udbg_init(void) | |||
69 | 69 | ||
70 | BUG_ON(hvc_udbg_dev); | 70 | BUG_ON(hvc_udbg_dev); |
71 | 71 | ||
72 | hp = hvc_alloc(0, NO_IRQ, &hvc_udbg_ops, 16); | 72 | hp = hvc_alloc(0, 0, &hvc_udbg_ops, 16); |
73 | if (IS_ERR(hp)) | 73 | if (IS_ERR(hp)) |
74 | return PTR_ERR(hp); | 74 | return PTR_ERR(hp); |
75 | 75 | ||
diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c index 52fdf60bdbe2..a1b0a75c3eae 100644 --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c | |||
@@ -176,7 +176,7 @@ static int __init xen_hvc_init(void) | |||
176 | xencons_irq = bind_evtchn_to_irq(xen_start_info->console.domU.evtchn); | 176 | xencons_irq = bind_evtchn_to_irq(xen_start_info->console.domU.evtchn); |
177 | } | 177 | } |
178 | if (xencons_irq < 0) | 178 | if (xencons_irq < 0) |
179 | xencons_irq = 0; /* NO_IRQ */ | 179 | xencons_irq = 0; |
180 | else | 180 | else |
181 | irq_set_noprobe(xencons_irq); | 181 | irq_set_noprobe(xencons_irq); |
182 | 182 | ||
diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c index b9040bec36bd..df7e7a0a5e6c 100644 --- a/drivers/tty/hvc/hvcs.c +++ b/drivers/tty/hvc/hvcs.c | |||
@@ -1203,7 +1203,7 @@ static void hvcs_close(struct tty_struct *tty, struct file *filp) | |||
1203 | { | 1203 | { |
1204 | struct hvcs_struct *hvcsd; | 1204 | struct hvcs_struct *hvcsd; |
1205 | unsigned long flags; | 1205 | unsigned long flags; |
1206 | int irq = NO_IRQ; | 1206 | int irq; |
1207 | 1207 | ||
1208 | /* | 1208 | /* |
1209 | * Is someone trying to close the file associated with this device after | 1209 | * Is someone trying to close the file associated with this device after |
@@ -1264,7 +1264,7 @@ static void hvcs_hangup(struct tty_struct * tty) | |||
1264 | struct hvcs_struct *hvcsd = tty->driver_data; | 1264 | struct hvcs_struct *hvcsd = tty->driver_data; |
1265 | unsigned long flags; | 1265 | unsigned long flags; |
1266 | int temp_open_count; | 1266 | int temp_open_count; |
1267 | int irq = NO_IRQ; | 1267 | int irq; |
1268 | 1268 | ||
1269 | spin_lock_irqsave(&hvcsd->lock, flags); | 1269 | spin_lock_irqsave(&hvcsd->lock, flags); |
1270 | /* Preserve this so that we know how many kref refs to put */ | 1270 | /* Preserve this so that we know how many kref refs to put */ |
diff --git a/drivers/tty/hvc/hvsi.c b/drivers/tty/hvc/hvsi.c index cdfa3e02d627..1b5f28bd7930 100644 --- a/drivers/tty/hvc/hvsi.c +++ b/drivers/tty/hvc/hvsi.c | |||
@@ -1237,7 +1237,7 @@ static int __init hvsi_console_init(void) | |||
1237 | hp->state = HVSI_CLOSED; | 1237 | hp->state = HVSI_CLOSED; |
1238 | hp->vtermno = *vtermno; | 1238 | hp->vtermno = *vtermno; |
1239 | hp->virq = irq_create_mapping(NULL, irq[0]); | 1239 | hp->virq = irq_create_mapping(NULL, irq[0]); |
1240 | if (hp->virq == NO_IRQ) { | 1240 | if (hp->virq == 0) { |
1241 | printk(KERN_ERR "%s: couldn't create irq mapping for 0x%x\n", | 1241 | printk(KERN_ERR "%s: couldn't create irq mapping for 0x%x\n", |
1242 | __func__, irq[0]); | 1242 | __func__, irq[0]); |
1243 | continue; | 1243 | continue; |