diff options
author | Jiri Slaby <jslaby@suse.cz> | 2012-03-05 08:51:52 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-03-08 14:37:58 -0500 |
commit | 2f16669d322e05171c9e1cfd94f402f7399bd2a3 (patch) | |
tree | 6a036cd0352928dd7056976a5f457c229322d67f /drivers/tty/hvc | |
parent | 87cab16beb882d3f9e61a2c0184fa7cf76de1f90 (diff) |
TTY: remove re-assignments to tty_driver members
All num, magic and owner are set by alloc_tty_driver. No need to
re-set them on each allocation site.
pti driver sets something different to what it passes to
alloc_tty_driver. It is not a bug, since we don't use the lines
parameter in any way. Anyway this is fixed, and now we do the right
thing.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Acked-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/hvc')
-rw-r--r-- | drivers/tty/hvc/hvc_console.c | 1 | ||||
-rw-r--r-- | drivers/tty/hvc/hvcs.c | 2 | ||||
-rw-r--r-- | drivers/tty/hvc/hvsi.c | 1 |
3 files changed, 0 insertions, 4 deletions
diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index b6b2d18fa38d..8880adf5fc6f 100644 --- a/drivers/tty/hvc/hvc_console.c +++ b/drivers/tty/hvc/hvc_console.c | |||
@@ -917,7 +917,6 @@ static int hvc_init(void) | |||
917 | goto out; | 917 | goto out; |
918 | } | 918 | } |
919 | 919 | ||
920 | drv->owner = THIS_MODULE; | ||
921 | drv->driver_name = "hvc"; | 920 | drv->driver_name = "hvc"; |
922 | drv->name = "hvc"; | 921 | drv->name = "hvc"; |
923 | drv->major = HVC_MAJOR; | 922 | drv->major = HVC_MAJOR; |
diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c index df7e7a0a5e6c..da0aa476804d 100644 --- a/drivers/tty/hvc/hvcs.c +++ b/drivers/tty/hvc/hvcs.c | |||
@@ -1499,8 +1499,6 @@ static int __devinit hvcs_initialize(void) | |||
1499 | goto index_fail; | 1499 | goto index_fail; |
1500 | } | 1500 | } |
1501 | 1501 | ||
1502 | hvcs_tty_driver->owner = THIS_MODULE; | ||
1503 | |||
1504 | hvcs_tty_driver->driver_name = hvcs_driver_name; | 1502 | hvcs_tty_driver->driver_name = hvcs_driver_name; |
1505 | hvcs_tty_driver->name = hvcs_device_node; | 1503 | hvcs_tty_driver->name = hvcs_device_node; |
1506 | 1504 | ||
diff --git a/drivers/tty/hvc/hvsi.c b/drivers/tty/hvc/hvsi.c index 1b5f28bd7930..60bc45164189 100644 --- a/drivers/tty/hvc/hvsi.c +++ b/drivers/tty/hvc/hvsi.c | |||
@@ -1088,7 +1088,6 @@ static int __init hvsi_init(void) | |||
1088 | if (!hvsi_driver) | 1088 | if (!hvsi_driver) |
1089 | return -ENOMEM; | 1089 | return -ENOMEM; |
1090 | 1090 | ||
1091 | hvsi_driver->owner = THIS_MODULE; | ||
1092 | hvsi_driver->driver_name = "hvsi"; | 1091 | hvsi_driver->driver_name = "hvsi"; |
1093 | hvsi_driver->name = "hvsi"; | 1092 | hvsi_driver->name = "hvsi"; |
1094 | hvsi_driver->major = HVSI_MAJOR; | 1093 | hvsi_driver->major = HVSI_MAJOR; |