diff options
author | Jiri Slaby <jslaby@suse.cz> | 2012-11-15 03:49:56 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-11-15 20:20:58 -0500 |
commit | 191c5f10275cfbb36802edadbdb10c73537327b4 (patch) | |
tree | 93e6f0d57cb1295fb7c461dbe5ecefafeb4ad15a /drivers/tty/ehv_bytechan.c | |
parent | d0f59141ca40159c9d142c0f62e9aea61f846539 (diff) |
TTY: call tty_port_destroy in the rest of drivers
After commit "TTY: move tty buffers to tty_port", the tty buffers are
not freed in some drivers. This is because tty_port_destructor is not
called whenever a tty_port is freed. This was an assumption I counted
with but was unfortunately untrue. So fix the drivers to fulfil this
assumption.
To be sure, the TTY buffers (and later some stuff) are gone along with
the tty_port, we have to call tty_port_destroy at tear-down places.
This is mostly where the structure containing a tty_port is freed.
This patch does exactly that -- put tty_port_destroy at those places.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/ehv_bytechan.c')
-rw-r--r-- | drivers/tty/ehv_bytechan.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/tty/ehv_bytechan.c b/drivers/tty/ehv_bytechan.c index 4ab936b7aac6..4193afb74a02 100644 --- a/drivers/tty/ehv_bytechan.c +++ b/drivers/tty/ehv_bytechan.c | |||
@@ -757,6 +757,7 @@ static int __devinit ehv_bc_tty_probe(struct platform_device *pdev) | |||
757 | return 0; | 757 | return 0; |
758 | 758 | ||
759 | error: | 759 | error: |
760 | tty_port_destroy(&bc->port); | ||
760 | irq_dispose_mapping(bc->tx_irq); | 761 | irq_dispose_mapping(bc->tx_irq); |
761 | irq_dispose_mapping(bc->rx_irq); | 762 | irq_dispose_mapping(bc->rx_irq); |
762 | 763 | ||
@@ -770,6 +771,7 @@ static int ehv_bc_tty_remove(struct platform_device *pdev) | |||
770 | 771 | ||
771 | tty_unregister_device(ehv_bc_driver, bc - bcs); | 772 | tty_unregister_device(ehv_bc_driver, bc - bcs); |
772 | 773 | ||
774 | tty_port_destroy(&bc->port); | ||
773 | irq_dispose_mapping(bc->tx_irq); | 775 | irq_dispose_mapping(bc->tx_irq); |
774 | irq_dispose_mapping(bc->rx_irq); | 776 | irq_dispose_mapping(bc->rx_irq); |
775 | 777 | ||