diff options
author | Lukasz Majewski <l.majewski@samsung.com> | 2014-09-24 04:27:10 -0400 |
---|---|---|
committer | Zhang Rui <rui.zhang@intel.com> | 2014-10-08 22:44:01 -0400 |
commit | 26bb0e9a1a938ec98ee07aa76533f1a711fba706 (patch) | |
tree | 0f17deb50d1cbfd45060c1da59d864ac143bdbfd /drivers/thermal/step_wise.c | |
parent | 52addcf9d6669fa439387610bc65c92fa0980cef (diff) |
thermal: step_wise: fix: Prevent from binary overflow when trend is dropping
It turns out that some boards can have instance->lower greater than 0 and
when thermal trend is dropping it results with next_target equal to -1.
Since the next_target is defined as unsigned long it is interpreted as
0xFFFFFFFF and larger than instance->upper.
As a result the next_target is set to instance->upper which ramps up to
maximal cooling device target when the temperature is steadily decreasing.
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Diffstat (limited to 'drivers/thermal/step_wise.c')
-rw-r--r-- | drivers/thermal/step_wise.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c index f251521baaa2..6705a0d746b3 100644 --- a/drivers/thermal/step_wise.c +++ b/drivers/thermal/step_wise.c | |||
@@ -76,7 +76,7 @@ static unsigned long get_target_state(struct thermal_instance *instance, | |||
76 | next_target = instance->upper; | 76 | next_target = instance->upper; |
77 | break; | 77 | break; |
78 | case THERMAL_TREND_DROPPING: | 78 | case THERMAL_TREND_DROPPING: |
79 | if (cur_state == instance->lower) { | 79 | if (cur_state <= instance->lower) { |
80 | if (!throttle) | 80 | if (!throttle) |
81 | next_target = THERMAL_NO_TARGET; | 81 | next_target = THERMAL_NO_TARGET; |
82 | } else { | 82 | } else { |