aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/target
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@infradead.org>2011-11-23 06:54:15 -0500
committerNicholas Bellinger <nab@linux-iscsi.org>2011-12-14 06:26:44 -0500
commit41e16e981679124c78c30f046d4f0b71d86ff1b2 (patch)
tree2db886814e0f8b9b39d8e8b836e3598d128d14e1 /drivers/target
parentef804a849ffae058a783e9dddd24cc1a555bbdb4 (diff)
target: remove the se_task task_error_status field
We only reach transport_complete_task once per task, so the test and set on task_error_status is never going to have an effect. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
-rw-r--r--drivers/target/target_core_transport.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index e13fafa6f526..ae112ac91c47 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -738,13 +738,7 @@ void transport_complete_task(struct se_task *task, int success)
738 } 738 }
739 739
740 if (cmd->t_tasks_failed) { 740 if (cmd->t_tasks_failed) {
741 if (!task->task_error_status) { 741 cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
742 task->task_error_status =
743 TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
744 cmd->scsi_sense_reason =
745 TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
746 }
747
748 INIT_WORK(&cmd->work, target_complete_failure_work); 742 INIT_WORK(&cmd->work, target_complete_failure_work);
749 } else { 743 } else {
750 atomic_set(&cmd->t_transport_complete, 1); 744 atomic_set(&cmd->t_transport_complete, 1);