target: change sprintf to snprintf in transport_dump_vpd_ident

"buf" is 128 characters and "vpd->device_identifier" is 256.  It makes
the static checkers complain.

Also bump VPD_TMP_BUF_SIZE to match INQUIRY_VPD_DEVICE_IDENTIFIER_LEN.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

1 files changed, 6 insertions, 3 deletions

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index bd587b70661a..96b64d57ebbb 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -907,15 +907,18 @@ int transport_dump_vpd_ident(
 
         switch (vpd->device_identifier_code_set) {
         case 0x01: /* Binary */
-                sprintf(buf, "T10 VPD Binary Device Identifier: %s\n",
+                snprintf(buf, sizeof(buf),
+                        "T10 VPD Binary Device Identifier: %s\n",
                         &vpd->device_identifier[0]);
                 break;
         case 0x02: /* ASCII */
-                sprintf(buf, "T10 VPD ASCII Device Identifier: %s\n",
+                snprintf(buf, sizeof(buf),
+                        "T10 VPD ASCII Device Identifier: %s\n",
                         &vpd->device_identifier[0]);
                 break;
         case 0x03: /* UTF-8 */
-                sprintf(buf, "T10 VPD UTF-8 Device Identifier: %s\n",
+                snprintf(buf, sizeof(buf),
+                        "T10 VPD UTF-8 Device Identifier: %s\n",
                         &vpd->device_identifier[0]);
                 break;
         default: