aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/target
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2013-01-24 02:06:37 -0500
committerNicholas Bellinger <nab@linux-iscsi.org>2013-02-13 14:27:51 -0500
commit1be2956d30b2b6200ebb26ffb758ed3c8071303c (patch)
treeb063414656f3a45045be867ee420f36861cb43a9 /drivers/target
parent1810053e8db3fd65f039229bde9e420278994300 (diff)
iscsi-target: make some temporary buffers larger
My static checker complains because we use sprintf() to print some unsigned ints into 10 byte buffers. In theory unsigned ints can take 10 characters and we need another for the terminator. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
-rw-r--r--drivers/target/iscsi/iscsi_target_parameters.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c
index d89164287d00..ca2be406f141 100644
--- a/drivers/target/iscsi/iscsi_target_parameters.c
+++ b/drivers/target/iscsi/iscsi_target_parameters.c
@@ -1095,11 +1095,11 @@ static int iscsi_check_acceptor_state(struct iscsi_param *param, char *value,
1095 SET_PSTATE_REPLY_OPTIONAL(param); 1095 SET_PSTATE_REPLY_OPTIONAL(param);
1096 } 1096 }
1097 } else if (IS_TYPE_NUMBER(param)) { 1097 } else if (IS_TYPE_NUMBER(param)) {
1098 char *tmpptr, buf[10]; 1098 char *tmpptr, buf[11];
1099 u32 acceptor_value = simple_strtoul(param->value, &tmpptr, 0); 1099 u32 acceptor_value = simple_strtoul(param->value, &tmpptr, 0);
1100 u32 proposer_value = simple_strtoul(value, &tmpptr, 0); 1100 u32 proposer_value = simple_strtoul(value, &tmpptr, 0);
1101 1101
1102 memset(buf, 0, 10); 1102 memset(buf, 0, sizeof(buf));
1103 1103
1104 if (!strcmp(param->name, MAXCONNECTIONS) || 1104 if (!strcmp(param->name, MAXCONNECTIONS) ||
1105 !strcmp(param->name, MAXBURSTLENGTH) || 1105 !strcmp(param->name, MAXBURSTLENGTH) ||
@@ -1503,8 +1503,8 @@ static int iscsi_enforce_integrity_rules(
1503 FirstBurstLength = simple_strtoul(param->value, 1503 FirstBurstLength = simple_strtoul(param->value,
1504 &tmpptr, 0); 1504 &tmpptr, 0);
1505 if (FirstBurstLength > MaxBurstLength) { 1505 if (FirstBurstLength > MaxBurstLength) {
1506 char tmpbuf[10]; 1506 char tmpbuf[11];
1507 memset(tmpbuf, 0, 10); 1507 memset(tmpbuf, 0, sizeof(tmpbuf));
1508 sprintf(tmpbuf, "%u", MaxBurstLength); 1508 sprintf(tmpbuf, "%u", MaxBurstLength);
1509 if (iscsi_update_param_value(param, tmpbuf)) 1509 if (iscsi_update_param_value(param, tmpbuf))
1510 return -1; 1510 return -1;