diff options
author | Christoph Hellwig <hch@lst.de> | 2011-09-13 17:09:01 -0400 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2011-10-23 23:20:38 -0400 |
commit | 82f1c8a4e7739eae9f1c32c2c419efdc19b8af41 (patch) | |
tree | e4b9141c59cbc1402b96fb34003205fe90d362df /drivers/target/loopback | |
parent | e6a2573f1f5d66f0456c433afdfc63f33fdf9008 (diff) |
target: push session reinstatement out of transport_generic_free_cmd
Push session reinstatement out of transport_generic_free_cmd into the only
caller that actually needs it. Clean up transport_generic_free_cmd a bit,
and remove the useless comment. I'd love to add a more useful kerneldoc
comment for it, but as this point I'm still a bit confused in where it
stands in the command release stack.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/loopback')
-rw-r--r-- | drivers/target/loopback/tcm_loop.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c index aa2d67997235..f0e701d27bd1 100644 --- a/drivers/target/loopback/tcm_loop.c +++ b/drivers/target/loopback/tcm_loop.c | |||
@@ -200,7 +200,7 @@ static void tcm_loop_check_stop_free(struct se_cmd *se_cmd) | |||
200 | * Release the struct se_cmd, which will make a callback to release | 200 | * Release the struct se_cmd, which will make a callback to release |
201 | * struct tcm_loop_cmd * in tcm_loop_deallocate_core_cmd() | 201 | * struct tcm_loop_cmd * in tcm_loop_deallocate_core_cmd() |
202 | */ | 202 | */ |
203 | transport_generic_free_cmd(se_cmd, 0, 0); | 203 | transport_generic_free_cmd(se_cmd, 0); |
204 | } | 204 | } |
205 | 205 | ||
206 | static void tcm_loop_release_cmd(struct se_cmd *se_cmd) | 206 | static void tcm_loop_release_cmd(struct se_cmd *se_cmd) |
@@ -388,7 +388,7 @@ static int tcm_loop_device_reset(struct scsi_cmnd *sc) | |||
388 | SUCCESS : FAILED; | 388 | SUCCESS : FAILED; |
389 | release: | 389 | release: |
390 | if (se_cmd) | 390 | if (se_cmd) |
391 | transport_generic_free_cmd(se_cmd, 1, 0); | 391 | transport_generic_free_cmd(se_cmd, 1); |
392 | else | 392 | else |
393 | kmem_cache_free(tcm_loop_cmd_cache, tl_cmd); | 393 | kmem_cache_free(tcm_loop_cmd_cache, tl_cmd); |
394 | kfree(tl_tmr); | 394 | kfree(tl_tmr); |