iscsit: use the itt_t abstract type

Use the special itt_t type defined by the iscsi headers and the initiator
to make sure it's an opaque value.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

1 files changed, 5 insertions, 5 deletions

diff --git a/drivers/target/iscsi/iscsi_target_util.c b/drivers/target/iscsi/iscsi_target_util.c
index b42cdeb153df..22bec9e899c0 100644
--- a/drivers/target/iscsi/iscsi_target_util.c
+++ b/drivers/target/iscsi/iscsi_target_util.c
@@ -351,7 +351,7 @@ int iscsit_check_unsolicited_dataout(struct iscsi_cmd *cmd, unsigned char *buf)
 
 struct iscsi_cmd *iscsit_find_cmd_from_itt(
         struct iscsi_conn *conn,
-        u32 init_task_tag)
+        itt_t init_task_tag)
 {
         struct iscsi_cmd *cmd;
 
@@ -371,7 +371,7 @@ struct iscsi_cmd *iscsit_find_cmd_from_itt(
 
 struct iscsi_cmd *iscsit_find_cmd_from_itt_or_dump(
         struct iscsi_conn *conn,
-        u32 init_task_tag,
+        itt_t init_task_tag,
         u32 length)
 {
         struct iscsi_cmd *cmd;
@@ -417,7 +417,7 @@ int iscsit_find_cmd_for_recovery(
         struct iscsi_session *sess,
         struct iscsi_cmd **cmd_ptr,
         struct iscsi_conn_recovery **cr_ptr,
-        u32 init_task_tag)
+        itt_t init_task_tag)
 {
         struct iscsi_cmd *cmd = NULL;
         struct iscsi_conn_recovery *cr;
@@ -855,7 +855,7 @@ static int iscsit_add_nopin(struct iscsi_conn *conn, int want_response)
         cmd->iscsi_opcode = ISCSI_OP_NOOP_IN;
         state = (want_response) ? ISTATE_SEND_NOPIN_WANT_RESPONSE :
                                 ISTATE_SEND_NOPIN_NO_RESPONSE;
-        cmd->init_task_tag = 0xFFFFFFFF;
+        cmd->init_task_tag = RESERVED_ITT;
         spin_lock_bh(&conn->sess->ttt_lock);
         cmd->targ_xfer_tag = (want_response) ? conn->sess->targ_xfer_tag++ :
                         0xFFFFFFFF;
@@ -1222,7 +1222,7 @@ int iscsit_tx_login_rsp(struct iscsi_conn *conn, u8 status_class, u8 status_deta
         hdr->opcode             = ISCSI_OP_LOGIN_RSP;
         hdr->status_class       = status_class;
         hdr->status_detail      = status_detail;
-        hdr->itt                = cpu_to_be32(conn->login_itt);
+        hdr->itt                = conn->login_itt;
 
         iov.iov_base            = &iscsi_hdr;
         iov.iov_len             = ISCSI_HDR_LEN;