diff options
author | Joe Perches <joe@perches.com> | 2013-02-20 15:16:13 -0500 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2013-03-06 16:24:23 -0500 |
commit | 33a606ac8020b47292bcfda30c7888c1ab5233e2 (patch) | |
tree | 90854660647b5eced80c6a9cfe2930a7425a50e7 /drivers/ssb/pcmcia.c | |
parent | e5652756ff36ed9e1283121f788e6a17117efcab (diff) |
ssb: Convert ssb_printk to ssb_<level>
Use a more current logging style.
Convert ssb_dbprint to ssb_dbg too.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/ssb/pcmcia.c')
-rw-r--r-- | drivers/ssb/pcmcia.c | 46 |
1 files changed, 20 insertions, 26 deletions
diff --git a/drivers/ssb/pcmcia.c b/drivers/ssb/pcmcia.c index fbafed5b729b..b413e0187087 100644 --- a/drivers/ssb/pcmcia.c +++ b/drivers/ssb/pcmcia.c | |||
@@ -143,7 +143,7 @@ int ssb_pcmcia_switch_coreidx(struct ssb_bus *bus, | |||
143 | 143 | ||
144 | return 0; | 144 | return 0; |
145 | error: | 145 | error: |
146 | ssb_printk(KERN_ERR PFX "Failed to switch to core %u\n", coreidx); | 146 | ssb_err("Failed to switch to core %u\n", coreidx); |
147 | return err; | 147 | return err; |
148 | } | 148 | } |
149 | 149 | ||
@@ -153,10 +153,9 @@ int ssb_pcmcia_switch_core(struct ssb_bus *bus, | |||
153 | int err; | 153 | int err; |
154 | 154 | ||
155 | #if SSB_VERBOSE_PCMCIACORESWITCH_DEBUG | 155 | #if SSB_VERBOSE_PCMCIACORESWITCH_DEBUG |
156 | ssb_printk(KERN_INFO PFX | 156 | ssb_info("Switching to %s core, index %d\n", |
157 | "Switching to %s core, index %d\n", | 157 | ssb_core_name(dev->id.coreid), |
158 | ssb_core_name(dev->id.coreid), | 158 | dev->core_index); |
159 | dev->core_index); | ||
160 | #endif | 159 | #endif |
161 | 160 | ||
162 | err = ssb_pcmcia_switch_coreidx(bus, dev->core_index); | 161 | err = ssb_pcmcia_switch_coreidx(bus, dev->core_index); |
@@ -192,7 +191,7 @@ int ssb_pcmcia_switch_segment(struct ssb_bus *bus, u8 seg) | |||
192 | 191 | ||
193 | return 0; | 192 | return 0; |
194 | error: | 193 | error: |
195 | ssb_printk(KERN_ERR PFX "Failed to switch pcmcia segment\n"); | 194 | ssb_err("Failed to switch pcmcia segment\n"); |
196 | return err; | 195 | return err; |
197 | } | 196 | } |
198 | 197 | ||
@@ -549,44 +548,39 @@ static int ssb_pcmcia_sprom_write_all(struct ssb_bus *bus, const u16 *sprom) | |||
549 | bool failed = 0; | 548 | bool failed = 0; |
550 | size_t size = SSB_PCMCIA_SPROM_SIZE; | 549 | size_t size = SSB_PCMCIA_SPROM_SIZE; |
551 | 550 | ||
552 | ssb_printk(KERN_NOTICE PFX | 551 | ssb_notice("Writing SPROM. Do NOT turn off the power! Please stand by...\n"); |
553 | "Writing SPROM. Do NOT turn off the power! " | ||
554 | "Please stand by...\n"); | ||
555 | err = ssb_pcmcia_sprom_command(bus, SSB_PCMCIA_SPROMCTL_WRITEEN); | 552 | err = ssb_pcmcia_sprom_command(bus, SSB_PCMCIA_SPROMCTL_WRITEEN); |
556 | if (err) { | 553 | if (err) { |
557 | ssb_printk(KERN_NOTICE PFX | 554 | ssb_notice("Could not enable SPROM write access\n"); |
558 | "Could not enable SPROM write access.\n"); | ||
559 | return -EBUSY; | 555 | return -EBUSY; |
560 | } | 556 | } |
561 | ssb_printk(KERN_NOTICE PFX "[ 0%%"); | 557 | ssb_notice("[ 0%%"); |
562 | msleep(500); | 558 | msleep(500); |
563 | for (i = 0; i < size; i++) { | 559 | for (i = 0; i < size; i++) { |
564 | if (i == size / 4) | 560 | if (i == size / 4) |
565 | ssb_printk("25%%"); | 561 | ssb_cont("25%%"); |
566 | else if (i == size / 2) | 562 | else if (i == size / 2) |
567 | ssb_printk("50%%"); | 563 | ssb_cont("50%%"); |
568 | else if (i == (size * 3) / 4) | 564 | else if (i == (size * 3) / 4) |
569 | ssb_printk("75%%"); | 565 | ssb_cont("75%%"); |
570 | else if (i % 2) | 566 | else if (i % 2) |
571 | ssb_printk("."); | 567 | ssb_cont("."); |
572 | err = ssb_pcmcia_sprom_write(bus, i, sprom[i]); | 568 | err = ssb_pcmcia_sprom_write(bus, i, sprom[i]); |
573 | if (err) { | 569 | if (err) { |
574 | ssb_printk(KERN_NOTICE PFX | 570 | ssb_notice("Failed to write to SPROM\n"); |
575 | "Failed to write to SPROM.\n"); | ||
576 | failed = 1; | 571 | failed = 1; |
577 | break; | 572 | break; |
578 | } | 573 | } |
579 | } | 574 | } |
580 | err = ssb_pcmcia_sprom_command(bus, SSB_PCMCIA_SPROMCTL_WRITEDIS); | 575 | err = ssb_pcmcia_sprom_command(bus, SSB_PCMCIA_SPROMCTL_WRITEDIS); |
581 | if (err) { | 576 | if (err) { |
582 | ssb_printk(KERN_NOTICE PFX | 577 | ssb_notice("Could not disable SPROM write access\n"); |
583 | "Could not disable SPROM write access.\n"); | ||
584 | failed = 1; | 578 | failed = 1; |
585 | } | 579 | } |
586 | msleep(500); | 580 | msleep(500); |
587 | if (!failed) { | 581 | if (!failed) { |
588 | ssb_printk("100%% ]\n"); | 582 | ssb_cont("100%% ]\n"); |
589 | ssb_printk(KERN_NOTICE PFX "SPROM written.\n"); | 583 | ssb_notice("SPROM written\n"); |
590 | } | 584 | } |
591 | 585 | ||
592 | return failed ? -EBUSY : 0; | 586 | return failed ? -EBUSY : 0; |
@@ -700,7 +694,7 @@ static int ssb_pcmcia_do_get_invariants(struct pcmcia_device *p_dev, | |||
700 | return -ENOSPC; /* continue with next entry */ | 694 | return -ENOSPC; /* continue with next entry */ |
701 | 695 | ||
702 | error: | 696 | error: |
703 | ssb_printk(KERN_ERR PFX | 697 | ssb_err( |
704 | "PCMCIA: Failed to fetch device invariants: %s\n", | 698 | "PCMCIA: Failed to fetch device invariants: %s\n", |
705 | error_description); | 699 | error_description); |
706 | return -ENODEV; | 700 | return -ENODEV; |
@@ -722,7 +716,7 @@ int ssb_pcmcia_get_invariants(struct ssb_bus *bus, | |||
722 | res = pcmcia_loop_tuple(bus->host_pcmcia, CISTPL_FUNCE, | 716 | res = pcmcia_loop_tuple(bus->host_pcmcia, CISTPL_FUNCE, |
723 | ssb_pcmcia_get_mac, sprom); | 717 | ssb_pcmcia_get_mac, sprom); |
724 | if (res != 0) { | 718 | if (res != 0) { |
725 | ssb_printk(KERN_ERR PFX | 719 | ssb_err( |
726 | "PCMCIA: Failed to fetch MAC address\n"); | 720 | "PCMCIA: Failed to fetch MAC address\n"); |
727 | return -ENODEV; | 721 | return -ENODEV; |
728 | } | 722 | } |
@@ -733,7 +727,7 @@ int ssb_pcmcia_get_invariants(struct ssb_bus *bus, | |||
733 | if ((res == 0) || (res == -ENOSPC)) | 727 | if ((res == 0) || (res == -ENOSPC)) |
734 | return 0; | 728 | return 0; |
735 | 729 | ||
736 | ssb_printk(KERN_ERR PFX | 730 | ssb_err( |
737 | "PCMCIA: Failed to fetch device invariants\n"); | 731 | "PCMCIA: Failed to fetch device invariants\n"); |
738 | return -ENODEV; | 732 | return -ENODEV; |
739 | } | 733 | } |
@@ -843,6 +837,6 @@ int ssb_pcmcia_init(struct ssb_bus *bus) | |||
843 | 837 | ||
844 | return 0; | 838 | return 0; |
845 | error: | 839 | error: |
846 | ssb_printk(KERN_ERR PFX "Failed to initialize PCMCIA host device\n"); | 840 | ssb_err("Failed to initialize PCMCIA host device\n"); |
847 | return err; | 841 | return err; |
848 | } | 842 | } |