diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-09-01 12:33:08 -0400 |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2012-09-05 19:44:19 -0400 |
commit | 78bfee0e1e2e22c3062b41be8db618e7484c8e35 (patch) | |
tree | b3241dba2b34f307f324ee8356c0155204144200 /drivers/spi | |
parent | b4b8482690d97ea5421acf71e9e397fe0c5a25b8 (diff) |
spi: spi-sh-hspi: drop frees of devm_ alloc'd data
devm free functions should not have to be explicitly used.
A semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
@@
(
* devm_kfree(...);
|
* devm_free_irq(...);
|
* devm_iounmap(...);
|
* devm_release_region(...);
|
* devm_release_mem_region(...);
)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/spi')
-rw-r--r-- | drivers/spi/spi-sh-hspi.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c index 934138c7b3d3..796c077ef439 100644 --- a/drivers/spi/spi-sh-hspi.c +++ b/drivers/spi/spi-sh-hspi.c | |||
@@ -283,7 +283,7 @@ static int __devinit hspi_probe(struct platform_device *pdev) | |||
283 | ret = spi_register_master(master); | 283 | ret = spi_register_master(master); |
284 | if (ret < 0) { | 284 | if (ret < 0) { |
285 | dev_err(&pdev->dev, "spi_register_master error.\n"); | 285 | dev_err(&pdev->dev, "spi_register_master error.\n"); |
286 | goto error2; | 286 | goto error1; |
287 | } | 287 | } |
288 | 288 | ||
289 | pm_runtime_enable(&pdev->dev); | 289 | pm_runtime_enable(&pdev->dev); |
@@ -292,8 +292,6 @@ static int __devinit hspi_probe(struct platform_device *pdev) | |||
292 | 292 | ||
293 | return 0; | 293 | return 0; |
294 | 294 | ||
295 | error2: | ||
296 | devm_iounmap(hspi->dev, hspi->addr); | ||
297 | error1: | 295 | error1: |
298 | clk_put(clk); | 296 | clk_put(clk); |
299 | error0: | 297 | error0: |
@@ -310,7 +308,6 @@ static int __devexit hspi_remove(struct platform_device *pdev) | |||
310 | 308 | ||
311 | clk_put(hspi->clk); | 309 | clk_put(hspi->clk); |
312 | spi_unregister_master(hspi->master); | 310 | spi_unregister_master(hspi->master); |
313 | devm_iounmap(hspi->dev, hspi->addr); | ||
314 | 311 | ||
315 | return 0; | 312 | return 0; |
316 | } | 313 | } |