diff options
author | Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> | 2012-12-15 17:50:51 -0500 |
---|---|---|
committer | Simon Horman <horms+renesas@verge.net.au> | 2013-01-24 19:24:21 -0500 |
commit | a99ebec16c0586ec0838558fd1a050801037ebc9 (patch) | |
tree | 6b828ffec233eb8d6e9cc72fd091651520bdf6c9 /drivers/sh | |
parent | 4a2e0d18f95e1ec2b264f66e7cedec7f3dc54b44 (diff) |
sh-pfc: Remove check for impossible error condition
The pfc pointer can't be NULL in the get and set value functions, remove
the error check.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Diffstat (limited to 'drivers/sh')
-rw-r--r-- | drivers/sh/pfc/gpio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/sh/pfc/gpio.c b/drivers/sh/pfc/gpio.c index 37493e5fe2ee..c11c1bb97c71 100644 --- a/drivers/sh/pfc/gpio.c +++ b/drivers/sh/pfc/gpio.c | |||
@@ -52,7 +52,7 @@ static void sh_gpio_set_value(struct sh_pfc *pfc, unsigned gpio, int value) | |||
52 | struct pinmux_data_reg *dr = NULL; | 52 | struct pinmux_data_reg *dr = NULL; |
53 | int bit = 0; | 53 | int bit = 0; |
54 | 54 | ||
55 | if (!pfc || sh_pfc_get_data_reg(pfc, gpio, &dr, &bit) != 0) | 55 | if (sh_pfc_get_data_reg(pfc, gpio, &dr, &bit) != 0) |
56 | BUG(); | 56 | BUG(); |
57 | else | 57 | else |
58 | sh_pfc_write_bit(dr, bit, value); | 58 | sh_pfc_write_bit(dr, bit, value); |
@@ -63,7 +63,7 @@ static int sh_gpio_get_value(struct sh_pfc *pfc, unsigned gpio) | |||
63 | struct pinmux_data_reg *dr = NULL; | 63 | struct pinmux_data_reg *dr = NULL; |
64 | int bit = 0; | 64 | int bit = 0; |
65 | 65 | ||
66 | if (!pfc || sh_pfc_get_data_reg(pfc, gpio, &dr, &bit) != 0) | 66 | if (sh_pfc_get_data_reg(pfc, gpio, &dr, &bit) != 0) |
67 | return -EINVAL; | 67 | return -EINVAL; |
68 | 68 | ||
69 | return sh_pfc_read_bit(dr, bit); | 69 | return sh_pfc_read_bit(dr, bit); |